VAPI-3542 fix(signaling): disable auto-reconnect before closing on disconnect - #13
Merged
Merged
Conversation
The rpc-websockets client is constructed with `reconnect: true` and `max_reconnects: 0` (unlimited), and the library only skips reconnecting when the close code is exactly 1000. Any other code reconnects forever — including 1001/StatusGoingAway, which pv-gateway sends on every close where it wants the device to come back (heartbeat timeout, and Handle's teardown backstop). _disconnect() removed all listeners and closed the socket but never disabled reconnect, so an explicit disconnect could leave a reconnect loop running behind a client that no longer has an "open" handler. The reconnected socket therefore never calls setMediaPreferences, never creates peer connections and never answers the heartbeat — an inert connection on the gateway with no liveness check on either side, which accumulates for as long as the process lives. Reconnect stays enabled for the lifetime of a live connection; it is only disabled in _disconnect(), where the caller has asked to tear this client down for good. Failing to disable it no longer prevents the close. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
smoghe-bw
changed the title
cguthrie-bw
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rpc-websockets client is constructed with
reconnect: trueandmax_reconnects: 0(unlimited), and the library only skips reconnecting when the close code is exactly 1000. Any other code reconnects forever — including 1001/StatusGoingAway, which pv-gateway sends on every close where it wants the device to come back (heartbeat timeout, and Handle's teardown backstop)._disconnect() removed all listeners and closed the socket but never disabled reconnect, so an explicit disconnect could leave a reconnect loop running behind a client that no longer has an "open" handler. The reconnected socket therefore never calls setMediaPreferences, never creates peer connections and never answers the heartbeat — an inert connection on the gateway with no liveness check on either side, which accumulates for as long as the process lives.
Reconnect stays enabled for the lifetime of a live connection; it is only disabled in _disconnect(), where the caller has asked to tear this client down for good. Failing to disable it no longer prevents the close.