Added waiting for staff and fixed sam

[Minc3]

No description provided.

[Minc3]

Now it's easy to tell when a report is ready for staff.

[BadgerCode]

Awesome thank you!
I'll try take a look over this later today

[Minc3]

Awesome,
The empty string I did for SAM is required because SAM expects there to be a reason for why you are removing the slay so I just put a space there so the command would work.

[BadgerCode]

Sorry I will need to test this tomorrow/later this week. I didn't have time today.
Once I've tested it, I will release your changes!

[BadgerCode]

Hm. I gave it a test, but for some reason the menu still showed the report as "Waiting"
This might be an issue with how I was testing it (with bots, local server/peer-to-peer server via the main menu)

From what I could tell, the status RDM_MANAGER_READYFORSTAFF was making it from the server to client, but for some reason the menu still shows the waiting status.

I shall have to give it another test

[Minc3]

The status is changed to waiting for staff when the victim has decided to keep the report and not forgive them.

So you will need to report a player that can respond to your report and when you see their response you are giving two options keep or forgive.

If you select keep then the status of the report is set to waiting for staff.

I tested with players not bots and a dedicated server.

[BadgerCode]

Hey!

Sorry for the delay on this. Busy few days for me.
I will give this another test sometime this week!

[callumok2004]

When a report status is set to in progress or finished, there is a check to ensure the previous status was "waiting", this does not check if the previous status could have also been "waiting for staff" causing the pending reports to be invalid.

[BadgerCode]

Hey.
Sorry for the delay on this. I've just not had the time for it 🙁

Thanks for taking a look at this @callumok2004
That does sound like a problem that might need fixing @Minc3

[Minc3]

I have found a few more SAM related issues that I would like to fix in this PR before merge.

@callumok2004 I believe that should fix the issue.
I'll review all my changes just to make sure I haven't missed anything.

[Minc3]

This weekend I'll have time to fix all the remaining SAM issues.

[Minc3]

I am testing all of the changes on my TTT server.

[Minc3]

Ready to be merged

[Minc3]

Fixed #51

The base branch was changed.

[BadgerCode]

Overall it looks fine, but I think this could do with some comprehensive testing as introducing a new status for reports is quite a significant change.

[Satton2]

@Minc3
https://youtu.be/SGfP8StcSAI
Hello there, found an interesting issue/bug with this status. You see, both the "Waiting" status and the "Waiting for staff" add +1 to the "Pending reports" counter, resulting in never ending pending reports.

EDIT: I believe that SAM related changes should be made in seperate PR to merge them right now, while new status will be waiting for it's time.