Skip to content

fix: record unwind error after cancel relabels run terminal #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkyberneees merged 1 commit into from
Sep 27, 2026
Merged

fix: record unwind error after cancel relabels run terminal #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cmd/odek/serve_runs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,14 +468,19 @@ func (r *serveRun) record(v any) error {
r.Status = "running"
}
case "token", "token_delta":
// A still-draining loop must not mutate a terminal run's result —
// A still-draining loop must not grow a terminal run's result —
// the snapshot served by GET /api/runs/{id} would change between
// polls after the run already completed/failed.
if c, _ := m["content"].(string); c != "" && !runStatusTerminal(r.Status) {
r.Result += c
}
case "error":
if msg, _ := m["message"].(string); msg != "" && !runStatusTerminal(r.Status) {
// First error wins. NOT terminal-gated: the cancel path flips the
// status to "cancelled" first and the unwinding loop's error event
// arrives afterwards — dropping it would leave the run with a
// terminal status but no explanation (and starve clients polling
// for the unwind). Repeated late errors must not overwrite it.
if msg, _ := m["message"].(string); msg != "" && r.Error == "" {
r.Error = msg
}
case "done":
Expand Down
Loading