Skip to content

Fix inconsistent apt usage and duplicate JSC package in Linux build instructions#1627

Merged
bkaradzic-microsoft merged 2 commits intoupdate-docsfrom
copilot/sub-pr-1624-another-one
Mar 10, 2026
Merged

Fix inconsistent apt usage and duplicate JSC package in Linux build instructions#1627
bkaradzic-microsoft merged 2 commits intoupdate-docsfrom
copilot/sub-pr-1624-another-one

Conversation

Copy link

Copilot AI commented Mar 10, 2026

The Linux build instructions listed libjavascriptcoregtk-4.1-dev in the base mandatory packages, causing it to be installed for all engine targets (including V8) and duplicating the engine-specific install step. The base command also used apt while engine-specific steps used apt-get.

Changes

  • Remove libjavascriptcoregtk-4.1-dev from base install — engine-specific packages now live only in their respective engine sections
  • Standardize on apt-get throughout the Linux section for consistency

Before:

sudo apt install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev libjavascriptcoregtk-4.1-dev g++ cmake ninja-build npm

After:

sudo apt-get install libgl1-mesa-dev x11proto-core-dev libx11-dev libcurl4-openssl-dev g++ cmake ninja-build npm

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: bkaradzic-microsoft <260535795+bkaradzic-microsoft@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on Linux building instructions update Fix inconsistent apt usage and duplicate JSC package in Linux build instructions Mar 10, 2026
@bkaradzic-microsoft bkaradzic-microsoft marked this pull request as ready for review March 10, 2026 14:05
@bkaradzic-microsoft bkaradzic-microsoft merged commit 0b71f3b into update-docs Mar 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants