Fix invalid CMake command in Linux building instructions#1625
Merged
bkaradzic-microsoft merged 2 commits intoupdate-docsfrom Mar 10, 2026
Merged
Fix invalid CMake command in Linux building instructions#1625bkaradzic-microsoft merged 2 commits intoupdate-docsfrom
bkaradzic-microsoft merged 2 commits intoupdate-docsfrom
Conversation
Co-authored-by: bkaradzic-microsoft <260535795+bkaradzic-microsoft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix building instructions based on review feedback
Fix invalid CMake command in Linux building instructions
Mar 10, 2026
bkaradzic-microsoft
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScriptCore cmake invocation in
BUILDING.mdcontained a stray-Dflag (-D -D NAPI_JAVASCRIPT_ENGINE=...), making it an invalid command that would fail immediately.Changes
-Dfrom the JavaScriptCore cmake command-B build/linuxto both JavaScriptCore and V8 cmake commands — consistent with every other platform section in the docsninjawithcmake --build build/linuxto match the out-of-source build pattern used elsewhereBefore/after for the broken command:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.