Skip to content

Fix invalid CMake command in Linux building instructions#1625

Merged
bkaradzic-microsoft merged 2 commits intoupdate-docsfrom
copilot/sub-pr-1624
Mar 10, 2026
Merged

Fix invalid CMake command in Linux building instructions#1625
bkaradzic-microsoft merged 2 commits intoupdate-docsfrom
copilot/sub-pr-1624

Conversation

Copy link

Copilot AI commented Mar 10, 2026

The JavaScriptCore cmake invocation in BUILDING.md contained a stray -D flag (-D -D NAPI_JAVASCRIPT_ENGINE=...), making it an invalid command that would fail immediately.

Changes

  • Remove stray -D from the JavaScriptCore cmake command
  • Add -B build/linux to both JavaScriptCore and V8 cmake commands — consistent with every other platform section in the docs
  • Replace bare ninja with cmake --build build/linux to match the out-of-source build pattern used elsewhere

Before/after for the broken command:

# Before (invalid)
cmake -G Ninja -D -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore

# After
cmake -B build/linux -G Ninja -D NAPI_JAVASCRIPT_ENGINE=JavaScriptCore

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: bkaradzic-microsoft <260535795+bkaradzic-microsoft@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix building instructions based on review feedback Fix invalid CMake command in Linux building instructions Mar 10, 2026
@bkaradzic-microsoft bkaradzic-microsoft marked this pull request as ready for review March 10, 2026 14:06
@bkaradzic-microsoft bkaradzic-microsoft merged commit 07ad0fa into update-docs Mar 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants