Skip to content

temurin-jre: correct extract_dir in autoupdate#2

Closed
B67687 wants to merge 119 commits intomasterfrom
fix/temurin-jre-extract-dir
Closed

temurin-jre: correct extract_dir in autoupdate#2
B67687 wants to merge 119 commits intomasterfrom
fix/temurin-jre-extract-dir

Conversation

@B67687
Copy link
Copy Markdown
Owner

@B67687 B67687 commented Apr 30, 2026

Summary

Fixes the extraction directory mismatch bug that causes temurin-jre updates to fail.

Problem

The autoupdate formula uses $matchTag-jre which adds a -jre suffix to the expected extraction directory. However, the actual extracted directory from the Temurin JRE ZIP files is just jdk-{tag} WITHOUT the -jre suffix.

Example:

  • Git tag: jdk-24.0.2+12
  • Scoop expects (wrong): jdk-24.0.2+12-jre
  • Actually extracted: jdk-24.0.2+12

This caused issue ScoopInstaller#552 where updating temurin-jre from 24.0.1-9 to 24.0.2-12 failed with "Could not find 'jdk-24.0.2+12-jre'".

Fix

Change autoupdate.extract_dir from $matchTag-jre to $matchTag.

Closes ScoopInstaller#552

  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated JRE extraction behavior so installs and autoupdates now unpack into the base JDK-tag directory (no -jre suffix), making install/update locations consistent.
    • Rolled in a newer Eclipse Temurin LTS JRE release (updated version, download, and integrity data).

github-actions Bot and others added 30 commits April 21, 2026 13:43
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the autoupdate template in bucket/temurin-jre.json by removing the -jre suffix from the extract_dir property. While this change correctly handles future updates, the manifest remains broken for the current version because the top-level extract_dir still contains the incorrect suffix and needs to be updated. Furthermore, a similar issue was identified in temurin-lts-jre.json that should also be addressed.

Comment thread bucket/temurin-jre.json
"find": "^([a-fA-F0-9]+)\\s"
},
"extract_dir": "$matchTag-jre"
"extract_dir": "$matchTag"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The fix for the autoupdate template is correct. However, the manifest remains broken for the current version because the top-level extract_dir (line 12) still contains the incorrect -jre suffix. It should be updated to jdk-26+35 to ensure the manifest works for users installing the current version. Additionally, temurin-lts-jre.json (visible in the repository context) appears to have the same incorrect $matchTag-jre pattern in its autoupdate section and should also be corrected to ensure future updates work correctly for that manifest as well.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

📝 Walkthrough

Walkthrough

Updated two Temurin JRE manifests: one changed extraction target from a -jre suffixed directory to the base tag directory; the other updated version, Windows x64 URL, SHA256, and likewise adjusted extract_dir and autoupdate extraction target to the base tag directory.

Changes

Cohort / File(s) Summary
Temurin JRE — extraction-only
bucket/temurin-jre.json
Changed extract_dir and autoupdate extract_dir target from $matchTag-jre to $matchTag so installs and autoupdates unpack into the base tag directory.
Temurin LTS JRE — release + extraction
bucket/temurin-lts-jre.json
Bumped version, updated Windows x64 download url and associated sha256, and changed extract_dir and autoupdate extract_dir target from $matchTag-jre to $matchTag.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I nudged a tag, removed a dash,
Directories tidy in a flash,
New LTS stride, a checksum hop,
Archives land where they should stop—
A little rabbit's tidy patch. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is well-structured with Problem, Fix, and Solution sections, clearly explaining the issue and its resolution, though it does not explicitly list all file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: correcting the extract_dir in autoupdate for temurin-jre, which is the primary fix in the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/temurin-jre-extract-dir

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@B67687
Copy link
Copy Markdown
Owner Author

B67687 commented Apr 30, 2026

/verify

@github-actions
Copy link
Copy Markdown

All changes look good.

Wait for review from human collaborators.

temurin-jre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@B67687
Copy link
Copy Markdown
Owner Author

B67687 commented Apr 30, 2026

/verify

@github-actions
Copy link
Copy Markdown

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

temurin-jre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

temurin-lts-jre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@B67687
Copy link
Copy Markdown
Owner Author

B67687 commented Apr 30, 2026

/verify

@github-actions
Copy link
Copy Markdown

All changes look good.

Wait for review from human collaborators.

temurin-jre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

temurin-lts-jre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@B67687 B67687 changed the title fix(temurin-jre): correct extract_dir in autoupdate - closes #552 fix(temurin-jre): correct extract_dir in autoupdate Apr 30, 2026
@B67687 B67687 changed the title fix(temurin-jre): correct extract_dir in autoupdate temurin-jre: correct extract_dir in autoupdate Apr 30, 2026
@B67687 B67687 closed this Apr 30, 2026
@B67687 B67687 deleted the fix/temurin-jre-extract-dir branch April 30, 2026 03:38
@B67687 B67687 restored the fix/temurin-jre-extract-dir branch April 30, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

temurin-jre update failed - Could not find 'jdk-24.0.2+12-jre'! (error 11)

6 participants