Skip to content

Comments

fix: Check for max level#23

Merged
AzureDoom merged 4 commits intoAzureDoom:mainfrom
GlobalHive:main
Feb 22, 2026
Merged

fix: Check for max level#23
AzureDoom merged 4 commits intoAzureDoom:mainfrom
GlobalHive:main

Conversation

@GlobalHive
Copy link

📌 Description

Looks like the MaxLevel check was missed in the level up procedure.
It check when using commands but not when leveling


🧪 Type of Change

Please check the types of changes your PR introduces:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Tests added / updated

👩‍💻 Implementation Details

Added "isMaxLevel" to LevelServiceImpl
Added checks for the notification

🛠 Changes

  • isMaxLevel -> LevelServiceImpl
  • && !isMaxLevel everywhere, where notifications are sended

✅ Checklist

Go over all the following items and check them before submitting your PR:

  • My code follows the project’s code style (simply run spotlessApply to apply formatting)
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • My changes generate no new warnings

@GlobalHive
Copy link
Author

Found a horrible bug at my environment code

java.lang.IllegalStateException: Store is currently processing! Ensure you aren't calling a store method from a system.
	at com.hypixel.hytale.component.Store.assertWriteProcessing(Store.java:2290)
	at com.hypixel.hytale.component.Store.addEntities(Store.java:654)
	at com.hypixel.hytale.component.Store.addEntities(Store.java:624)
	at com.hypixel.hytale.server.core.universe.world.chunk.EntityChunk$EntityChunkLoadingSystem.onComponentRemoved(EntityChunk.java:185)
	at com.hypixel.hytale.server.core.universe.world.chunk.EntityChunk$EntityChunkLoadingSystem.onComponentRemoved(EntityChunk.java:78)
	at com.hypixel.hytale.component.Store.removeComponentIfExists(Store.java:1348)
	at com.hypixel.hytale.component.Store.tryRemoveComponent(Store.java:1289)
	at com.hypixel.hytale.server.core.universe.world.chunk.WorldChunk.startsTicking(WorldChunk.java:251)
	at com.hypixel.hytale.server.core.universe.world.chunk.WorldChunk.updateFlag(WorldChunk.java:238)
	at com.hypixel.hytale.server.core.universe.world.chunk.WorldChunk.setFlag(WorldChunk.java:180)
	at com.hypixel.hytale.server.core.universe.world.World.loadChunkIfInMemory(World.java:733)
	at com.hypixel.hytale.server.core.universe.world.World.loadChunkIfInMemory(World.java:93)
	at com.hypixel.hytale.server.core.universe.world.IWorldChunks.getChunk(IWorldChunks.java:21)
	at ThirdParty(com.azuredoom:levelingcore)//com.azuredoom.levelingcore.utils.MobLevelingUtil.computeEnvironmentLevel(MobLevelingUtil.java:141)
	at ThirdParty(com.azuredoom:levelingcore)//com.azuredoom.levelingcore.utils.MobLevelingUtil.lambda$computeDynamicLevel$0(MobLevelingUtil.java:54)
	at java.base/java.util.Optional.map(Optional.java:260)
	at ThirdParty(com.azuredoom:levelingcore)//com.azuredoom.levelingcore.utils.MobLevelingUtil.computeDynamicLevel(MobLevelingUtil.java:49)
	at ThirdParty(com.azuredoom:levelingcore)//com.azuredoom.levelingcore.systems.level.MobLevelSystem.drainPending(MobLevelSystem.java:122)
	at ThirdParty(com.azuredoom:levelingcore)//com.azuredoom.levelingcore.systems.level.MobLevelSystem.tick(MobLevelSystem.java:101)
	at com.hypixel.hytale.component.system.tick.EntityTickingSystem.doTick(EntityTickingSystem.java:92)
	at com.hypixel.hytale.component.system.tick.EntityTickingSystem.tick(EntityTickingSystem.java:36)
	at com.hypixel.hytale.component.Store.tick(Store.java:1974)
	at com.hypixel.hytale.component.system.tick.ArchetypeTickingSystem.tick(ArchetypeTickingSystem.java:36)
	at com.hypixel.hytale.component.Store.tickInternal(Store.java:1930)
	at com.hypixel.hytale.component.Store.tick(Store.java:1900)
	at com.hypixel.hytale.server.core.universe.world.World.tick(World.java:454)
	at com.hypixel.hytale.server.core.util.thread.TickingThread.run(TickingThread.java:95)
	at java.base/java.lang.Thread.run(Thread.java:1474)

I was accessing the chunk while it gets read / written... fixed in last commit

@AzureDoom
Copy link
Owner

Thanks! Will get out here soon as a hitfix!

@AzureDoom AzureDoom merged commit 03e83fa into AzureDoom:main Feb 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants