Merged
Conversation
Author
|
Found a horrible bug at my environment code I was accessing the chunk while it gets read / written... fixed in last commit |
Owner
|
Thanks! Will get out here soon as a hitfix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Looks like the MaxLevel check was missed in the level up procedure.
It check when using commands but not when leveling
🧪 Type of Change
Please check the types of changes your PR introduces:
👩💻 Implementation Details
Added "isMaxLevel" to LevelServiceImpl
Added checks for the notification
🛠 Changes
✅ Checklist
Go over all the following items and check them before submitting your PR:
spotlessApplyto apply formatting)