Derive ARM auth scopes from endpoint URL #928
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -126,7 +126,7 @@ export function emitClients(module: rust.ModuleContainer): ClientModules | undef | |
| } | ||
|
|
||
| // if there's a credential param, create the necessary auth policy | ||
| const authPolicy = getAuthPolicy(constructor, use, endpointParamName); | ||
| if (authPolicy) { | ||
| body += `${indent.get()}${authPolicy}\n`; | ||
| } | ||
|
|
@@ -680,11 +680,19 @@ function getHeaderTraitDocComment(indent: helpers.indentation, module: rust.Modu | |
| * @param use the use statement builder currently in scope | ||
| * @returns the auth policy instantiation code or undefined if not required | ||
| */ | ||
| function getAuthPolicy(ctor: rust.Constructor, use: Use, endpointParamName: string): string | undefined { | ||
| for (const param of ctor.params) { | ||
| const arcTokenCred = utils.asTypeOf<rust.TokenCredential>(param.type, 'tokenCredential', 'arc'); | ||
| if (arcTokenCred) { | ||
| use.add('azure_core::http::policies', 'auth::BearerTokenAuthorizationPolicy', 'Policy'); | ||
| const hasRelativeScopes = arcTokenCred.scopes.some(s => !s.startsWith('http')); | ||
| if (hasRelativeScopes) { | ||
|
Comment on lines
+688
to
+689
There was a problem hiding this comment. This introduces new branching behavior for scope classification. Add an emitter test that covers (1) relative scopes (
Member
Author
There was a problem hiding this comment. @copilot apply changes based on active feedback |
||
| // Relative scopes (e.g. "user_impersonation" from ARM specs) must be | ||
| // qualified at runtime using the service endpoint so that sovereign | ||
| // clouds work correctly. The standard Azure SDK pattern is | ||
| // "{endpoint_origin}/.default". | ||
| return `let auth_policy: Arc<dyn Policy> = Arc::new(BearerTokenAuthorizationPolicy::new(credential, vec![format!("{}/.default", ${endpointParamName}.origin().ascii_serialization())]));`; | ||
| } | ||
| const scopes = new Array<string>(); | ||
| for (const scope of arcTokenCred.scopes) { | ||
| scopes.push(`"${scope}"`); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!s.startsWith('http')misclassifies non-HTTP absolute scopes (e.g.,api://{client-id}/.default) as “relative”, which would incorrectly replace them with{endpoint_origin}/.default. Consider detecting “absolute” scopes by checking for a URI scheme (e.g.,s.includes('://')) or using URL parsing where possible, and only treating truly relative bare scopes as relative.