Skip to content

Add Spector tests for pageable LROs #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add Spector tests for pageable LROs #3695

Copilot wants to merge 12 commits into from
+278 −45

Conversation

Copy link
Contributor

Copilot AI commented Dec 25, 2025 •
edited by msyyc
Loading

context: #3688

fix #3655

NOTE:

  • Since there is no existing typespec template for defining pageable LROs, I referred to the current LRO and paging templates to handle this case. Both typespec-autorest and typespec-python can generate this case as a pageable LRO.
  • Regarding runtime behavior, I have based it on the actual interactive process between client and service recorded here.

Copilot AI and others added 2 commits December 25, 2025 02:08
@msyyc
Add pageable LRO Spector tests
4bba934 
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
@msyyc
Apply code formatting
6d6f86e 
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Spector tests for pageable LROs Add Spector tests for pageable LROs Dec 25, 2025
Copilot AI requested a review from msyyc December 25, 2025 02:16
msyyc
msyyc reviewed Dec 25, 2025
View reviewed changes
msyyc
msyyc reviewed Dec 25, 2025
View reviewed changes
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 25, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/Azure/typespec-azure/@azure-tools/azure-http-specs@3695

commit: 420c1f9

@msyyc
Add changelog for pageable LRO Spector tests
5dae65e 
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot AI requested a review from msyyc December 25, 2025 03:58
@msyyc msyyc mentioned this pull request Dec 29, 2025
Merged
1 task
@msyyc msyyc marked this pull request as ready for review December 29, 2025 09:53
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jan 5, 2026
@msyyc
[Python] Support lro-paging operation (#9272)
c0aa69f 
fix #9271

spector case: 
- [ ] Azure/typespec-azure#3695
@msyyc msyyc mentioned this pull request Jan 5, 2026
Open
7 tasks
@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Jan 5, 2026
Merged
weidongxu-microsoft
weidongxu-microsoft approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codegen is good for Java. I haven't run the mockapi though.

If Python run it and runtime is good, it would be good for me.

github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jan 5, 2026
@weidongxu-microsoft
http-client-java, support method with kind=lropaging (#9284)
8182569 
Mainly a bug fix, when method of lropaging contains more than one
response (and the 200 response is not the first in array).
Previous code took a too simplistic approach (of always checking the
first response in array in pageable op).

Tested with Azure/typespec-azure#3695, compile
pass, impl code looks correct.
May adjust more (if necessary), when verify that test case after
azure-http-specs publish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tadelesh tadelesh tadelesh approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@msyyc msyyc Awaiting requested review from msyyc

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

@msyyc msyyc

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need Spector tests for pageable LROs

4 participants

@tadelesh @weidongxu-microsoft @msyyc