feat: add shared metrics utility for report building#232
Open
JasonXuDeveloper wants to merge 3 commits intoAzure:unstable-replayfrom
Open
feat: add shared metrics utility for report building#232JasonXuDeveloper wants to merge 3 commits intoAzure:unstable-replayfrom
JasonXuDeveloper wants to merge 3 commits intoAzure:unstable-replayfrom
Conversation
3 tasks
JasonXuDeveloper
force-pushed
the
replay/pr3
branch
from
44a4430 to
d0a34d4
Compare
- Fix "traget" → "target" typo in LoadProfileSpec comment - Fix "letencies" → "latencies" typo in runner CLI flag description - Add empty specs validation in loadConfig to prevent index-out-of-range panic when config file has no specs - Preserve nodeAffinity from runnergroup spec when CLI --affinity flag is not provided Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Add foundation types for the timeseries replay system: - ReplayRequest, ReplayProfile, ReplayProfileSpec types with validation - IsReplayMode() method on RunnerGroupSpec for detecting replay configs - ReplayProfileSpec field in RunnerGroupSpec for distributed mode - Sample replay profile and runner group config test data Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Extract shared report-building logic into metrics.BuildPercentileLatenciesReport() to avoid duplication between runner and replay report builders. Refactor buildRunnerMetricReport() to use the shared utility. Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
JasonXuDeveloper
force-pushed
the
replay/pr3
branch
from
d0a34d4 to
5387125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metrics.BuildPercentileLatenciesReport()shared utility functionbuildRunnerMetricReport()to use the shared utility, replacing ~15 lines with a single callTest plan
go build ./...passesgo vet ./...passesgo test ./metrics/...passes