Merged
Conversation
nytian
approved these changes
Apr 21, 2025
bachuv
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing some Kusto queries for our dashboard, I noticed that we have all zeros for table storage read metrics. This is likely a regression from when we swapped Azure Storage SDKs, which required a big code refactor. It's important that we fix this so that we have an accurate idea of the amount of data we're reading from table storage, which appears to be a contributing factor to several incidents.
I added some tiny code cleanup changes in this PR as well, but the main focus is on adding the missing table storage read metrics.