Add timeout wehn Read&Write Parititon Table #1200
Merged
Conversation
nytian
commented
Apr 10, 2025
| try | ||
| { | ||
| ReadTableReponse response = await this.tableLeaseManager.ReadAndWriteTableAsync(isShuttingDown, forcefulShutdownToken); | ||
| using var timeoutCts = new CancellationTokenSource(TimeSpan.FromSeconds(2)); |
Collaborator
Author
There was a problem hiding this comment.
Reading and writing the partition table should typically complete within milliseconds. And since we also need time to process the table info, I think a 2-second timeout is a reasonable bound. But please let me know if you have any thoughts about this.
Member
There was a problem hiding this comment.
I suggest making this configurable. That way if we find out that this gets triggered too often in production and causes unexpected issues, we can give customers instructions for how to mitigate.
nytian
commented
Apr 11, 2025
| /// If the operation exceeds the timeout, a PartitionManagerWarning is logged and the operation is retried. | ||
| /// The default time is 2 seconds. | ||
| /// </summary> | ||
| public TimeSpan PartitionTableOperationTimeout { get; set; } = TimeSpan.FromSeconds(2); |
Collaborator
Author
There was a problem hiding this comment.
To make this configurable for DF customers, I also need to add this at webjobs extensions here . I will update that once this PR is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadAndWriteTableAsyncat TablePartitionManager.This helps guard against cases where the read or write hangs silently, as Azure Storage client has its own retry policies. If the timeout is hit, a
PartitionManagerWarningis logged and the operation is retried.