Skip to content

Fix Concurrent Modification Error in IsControlQueueProcessingMessages #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nytian merged 2 commits into from
Apr 7, 2025
Merged

Fix Concurrent Modification Error in IsControlQueueProcessingMessages #1199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d639a
initial commit
nytian Apr 6, 2025
f0a2374
update by comment
nytian Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/DurableTask.AzureStorage/OrchestrationSessionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ public bool IsControlQueueReceivingMessages(string partitionId)

public bool IsControlQueueProcessingMessages(string partitionId)
{
return this.activeOrchestrationSessions.Values.Where(session => string.Equals(session.ControlQueue.Name, partitionId)).Any();
lock (this.messageAndSessionLock)
{
return this.activeOrchestrationSessions.Values.Where(session => string.Equals(session.ControlQueue.Name, partitionId)).Any();
}
}

async Task DequeueLoop(string partitionId, ControlQueue controlQueue, CancellationToken cancellationToken)
Expand Down
Loading