Repository navigation
Align paired sync/aio clients with Azure SDK contracts - #103
Open
hallvictoria wants to merge 11 commits into
Open
hallvictoria wants to merge 11 commits into
hallvictoria wants to merge 11 commits into
Conversation
hallvictoria
force-pushed
the
feature/python-sync-aio-contract
branch
from
October 12, 2026 16:23
86d43e0 to
21c4d5c
Compare
David Burg (daviburg)
left a comment
Member
There was a problem hiding this comment.
[Dobby] Connector SDK review: two medium-priority runtime defects reproduced on the current head; see the separate inline comments. The earlier constructor-timeout forwarding finding no longer reproduces after the latest SDK update, so it is not included as an open finding.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align all 99 generated connector clients with Azure SDK conventions while retaining paired synchronous root and asynchronous
azure.connectors.aiosurfaces. The final catalog is reproducible offline from 99 committed Swagger snapshots captured from live BTS4 managed connector metadata inwestus, with generator and output hashes pinned ingeneration.manifest.json.This revision resolves the remaining review findings across generated API shape, Azure Core paging and polling contracts, exception compatibility, statically discoverable package exports, required model fields, samples, and generation provenance.
Paired Generator PR
d3bc32c1b5fd0781a317fbd16f93a082e362ee93Changes
Generated clients
Args,Returns, andRaisesdocumentation to every generated operation.ItemPagedandAsyncItemPagedwithout public continuation controls.list_*pagers over their primary arrays.begin_*operations throughLROPollerandAsyncLROPoller.SDK, provenance, and samples
ConnectorExceptionderive from Azure CoreHttpResponseErrorwhile retaining connector operation, status, and response-body context.Tests
extPage` traversal and primary collection selection when bounded envelopes also contain auxiliary array metadata.
Testing
pytest): 4,925 passedpython -m flake8 --config .flake8 --extend-ignore=D)Additional validation:
git diff --checkpassed.Checklist