-
Notifications
You must be signed in to change notification settings - Fork 811
Add test for building parameters with extends and base merging using interpolation #18660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Test this change out locally with the following install scripts (Action run 20732592699) VSCode
Azure CLI
|
Dotnet Test Results 102 files - 51 102 suites - 51 41m 42s ⏱️ - 20m 56s Results for commit c95f1a2. ± Comparison against base commit 50ca350. This pull request removes 1949 and adds 662 tests. Note that renamed tests count towards both. |
| var result = await Bicep(CreateDefaultSettings(), "build-params", mainParamsPath, "--stdout"); | ||
|
|
||
| result.Should().Succeed(); | ||
| result.Stdout.Should().NotBeEmpty(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be an assertion about the content of the compiled params file? I think we would want to explicitly validate that bar compiles to "my-value-foo"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the assertion in this commit; da85efa
Description
Closes #18272
Added a new integration test for
build-paramsthat covers extendable parameter files where the base file contains interpolated values.The test provisions
base.bicepparam,main.bicepparam,main.bicepunder the extendable params feature flag and runsbuild-params --stdout.Checklist
Microsoft Reviewers: Open in CodeFlow