Rca tool - #135
Conversation
…orosync/cluster rename, conditional warnings on SAP
…for releases, adding macos and windows, and adding vscode extension
PR #135 Review - RCA Tool by fede2crMetadata
Scope Reviewed
Executive Summary
Findings (Ordered by Severity)
Detailed FindingsF-001 - Non-portable tag step on Windows matrix jobsSeverity: High. Why this matters:
Evidence:
The workflow calls a Bash script using: - name: Set crate versions from tag
if: startsWith(github.ref, 'refs/tags/v')
run: .github/scripts/set-crate-version-from-tag.shThe matrix includes Windows runners: - os: windows
arch: amd64
runner: windows-latestOn Windows, default Impact:
Recommended fix: Use one of the following approaches:
Minimal tactical patch: - name: Set crate versions from tag
if: startsWith(github.ref, 'refs/tags/v') && matrix.os != 'windows'
run: .github/scripts/set-crate-version-from-tag.shAlternative tactical patch: - name: Set crate versions from tag
if: startsWith(github.ref, 'refs/tags/v')
shell: bash
run: bash .github/scripts/set-crate-version-from-tag.shValidation after fix:
F-002 - Worker version constant is not actually declaredSeverity: Low. Why this matters:
Evidence: Current line content effectively places declaration text inside a single-line comment: // Version is only logged when debug mode is enabled\nconst WORKER_VERSION = '2025-12-23-nested-gzip';Impact:
Recommended fix: Replace with two real lines: // Version is only logged when debug mode is enabled
const WORKER_VERSION = '2025-12-23-nested-gzip';Validation after fix:
Suggested Merge Gate
|
|
As Alvaro Figueroa (@fede2cr) provided evidence. The powershell is actually able to manage the shell script properly during the build. So this is not a blocker anymore |
|
Alvaro Figueroa (@fede2cr) please schedule time with scotro to ensure this is properly released with TRIP involvement and intention. We have requirements to meet when releasing anything in this branch |
Adding rca-tool: