[Storage] Fix sync list_shares test leaking shares due to wrong cleanup prefix#47595
Merged
weirongw23-msft merged 1 commit intoJun 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a resource-leak bug in the synchronous file-share test suite. The test test_list_shares_with_num_results_and_marker created shares using the "listshare" prefix but cleaned up with the default prefix "share", so cleanup matched nothing and left shares on the account. The fix passes the correct prefix to _delete_shares(), aligning the sync test with its async equivalent.
Changes:
- Pass the
"listshare"prefix to_delete_shares()so the test cleans up the shares it actually created.
jalauzon-msft
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_list_shares_with_num_results_and_markercreated shares with the"listshare"prefix but calledself._delete_shares()with no argument, which defaults toTEST_SHARE_PREFIX("share"). Since"listshare*"names do not start with"share", the cleanup matched nothing and leaked the shares onto the account.Pass the
"listshare"prefix to_delete_shares()so the test removes the shares it created, matching the async version.