-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix UnboundLocalError in prompty response formatting when inputs are omitted #47005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
posaninagendra
merged 3 commits into
main
from
copilot/fix-unbound-local-variable-sample-input
May 20, 2026
+54
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
ab5969c
fix(evaluation): initialize sample_input in prompty format_llm_response
Copilot d936edb
Merge branch 'main' into copilot/fix-unbound-local-variable-sample-input
posaninagendra e66ecc3
Merge branch 'main' into copilot/fix-unbound-local-variable-sample-input
posaninagendra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_prompty_format_llm_response.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # --------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # --------------------------------------------------------- | ||
|
|
||
| import asyncio | ||
| from types import SimpleNamespace | ||
|
|
||
| import pytest | ||
|
|
||
| from azure.ai.evaluation._legacy.prompty._utils import format_llm_response | ||
|
|
||
|
|
||
| class _FakeResponse: | ||
| def __init__(self): | ||
| self.usage = SimpleNamespace(prompt_tokens=1, completion_tokens=2, total_tokens=3) | ||
| self.choices = [ | ||
| SimpleNamespace( | ||
| finish_reason="stop", | ||
| message=SimpleNamespace(role="assistant", content="test-output"), | ||
| ) | ||
| ] | ||
| self.model = "test-model" | ||
|
|
||
| def model_dump(self): | ||
| return { | ||
| "choices": [ | ||
| { | ||
| "message": { | ||
| "role": "assistant", | ||
| "content": "test-output", | ||
| } | ||
| } | ||
| ] | ||
| } | ||
|
|
||
|
|
||
| @pytest.mark.unittest | ||
| def test_format_llm_response_with_no_inputs_sets_empty_sample_input(): | ||
| response = _FakeResponse() | ||
|
|
||
| result = asyncio.run( | ||
| format_llm_response( | ||
| response=response, | ||
| is_first_choice=True, | ||
| response_format={"type": "text"}, | ||
| outputs=None, | ||
| inputs=None, | ||
| ) | ||
| ) | ||
|
|
||
| assert result["llm_output"] == "test-output" | ||
| assert result["sample_input"] == "" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.