[AutoPR azure-mgmt-weightsandbiases]-generated-from-SDK Generation - Python-6318761#46983
Open
azure-sdk wants to merge 1 commit into
Open
[AutoPR azure-mgmt-weightsandbiases]-generated-from-SDK Generation - Python-6318761#46983azure-sdk wants to merge 1 commit into
azure-sdk wants to merge 1 commit into
Conversation
…Biases.Management/tspconfig.yaml', API Version: 2024-09-18, SDK Release Type: beta, and CommitSHA: 'b373ded4a6c77a9f541ca8f020fd2072db632751' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6318761 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the azure-mgmt-weightsandbiases Python management SDK from a new TypeSpec/REST API spec commit, migrating packaging to pyproject.toml and introducing new generated runtime/model infrastructure changes.
Changes:
- Update generator metadata to spec commit
b373ded4a6c77a9f541ca8f020fd2072db632751and bump version to1.0.0b2. - Migrate packaging from
setup.py/sdk_packaging.tomlto PEP 621pyproject.toml(and adjust Python support to 3.10+). - Add
cloud_settingparameter wiring to sync/async clients and configuration, plus various generated code/runtime updates.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/tsp-location.yaml | Advances spec commit reference used for generation. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/setup.py | Removed in favor of pyproject.toml packaging. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/sdk_packaging.toml | Removed; packaging metadata moved into pyproject.toml. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/pyproject.toml | New PEP 621 packaging config, deps, and tool settings. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/operations/_patch.py | Regenerated header + modern typing for __all__. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/operations/_operations.py | Regenerated operations incl. paging, streaming/decompress, and error handling changes. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/models/_patch.py | Regenerated header + modern typing for __all__. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/models/_models.py | Updated model typings/docstrings to built-in generics and simplified summaries. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/models/_enums.py | Punctuation/docstring normalization in enums. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/aio/operations/_patch.py | Regenerated header + modern typing for __all__. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/aio/operations/_operations.py | Regenerated async operations incl. paging, streaming/decompress, and error handling changes. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/aio/_patch.py | Regenerated header + modern typing for __all__. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/aio/_configuration.py | Adds cloud_setting parameter and related doc updates (async). |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/aio/_client.py | Adds keyword-only cloud_setting and Self import compatibility (async). |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_version.py | Version bump to 1.0.0b2. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_utils/serialization.py | Refactors typing, removes eval, and adjusts serialization/deserialization helpers. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_utils/model_base.py | Significant model runtime updates incl. XML namespace handling, defaults, and deserialization behavior. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_serialization.py | Removed legacy serialization module (consolidated into _utils). |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_patch.py | Regenerated header + modern typing for __all__. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_model_base.py | Removed legacy model base (moved to _utils/model_base.py). |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_configuration.py | Adds cloud_setting parameter and related doc updates (sync). |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/weightsandbiases/_client.py | Adds keyword-only cloud_setting and Self import compatibility (sync). |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/mgmt/init.py | Adds type-ignore for namespace package path extension. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/azure/init.py | Adds type-ignore for namespace package path extension. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/apiview-properties.json | Adds cross-language version marker. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/_metadata.json | New generation metadata file replacing _meta.json. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/_meta.json | Removed legacy generator metadata file. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/README.md | Updates stated Python support to 3.10+. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/MANIFEST.in | Updates sdist include rules to match new layout/metadata. |
| sdk/weightsandbiases/azure-mgmt-weightsandbiases/CHANGELOG.md | Adds 1.0.0b2 entry documenting cloud_setting. |
Comment on lines
946
to
967
| @@ -856,7 +960,10 @@ def _get_deserialize_callable_from_annotation( # pylint: disable=too-many-retur | |||
| except (AttributeError, IndexError): | |||
| pass | |||
| try: | |||
| if annotation._name in ["List", "Set", "Tuple", "Sequence"]: # pyright: ignore | |||
| annotation_name = ( | |||
| annotation.__name__ if hasattr(annotation, "__name__") else annotation._name # pyright: ignore | |||
| ) | |||
| if annotation_name.lower() in ["list", "set", "tuple", "sequence"]: | |||
| if len(annotation.__args__) > 1: # pyright: ignore | |||
Comment on lines
135
to
+140
| async def extract_data(pipeline_response): | ||
| deserialized = pipeline_response.http_response.json() | ||
| list_of_elem = _deserialize(List[_models.Operation], deserialized.get("value", [])) | ||
| list_of_elem = _deserialize( | ||
| List[_models.Operation], | ||
| deserialized.get("value", []), | ||
| ) |
Comment on lines
158
to
165
| def build_instances_delete_request( | ||
| resource_group_name: str, instancename: str, subscription_id: str, **kwargs: Any | ||
| ) -> HttpRequest: | ||
| _headers = case_insensitive_dict(kwargs.pop("headers", {}) or {}) | ||
| _params = case_insensitive_dict(kwargs.pop("params", {}) or {}) | ||
|
|
||
| api_version: str = kwargs.pop("api_version", _params.pop("api-version", "2024-09-18")) | ||
| accept = _headers.pop("Accept", "application/json") | ||
|
|
||
| # Construct URL | ||
| _url = "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.WeightsAndBiases/instances/{instancename}" |
Comment on lines
175
to
+177
| _params["api-version"] = _SERIALIZER.query("api_version", api_version, "str") | ||
|
|
||
| # Construct headers | ||
| _headers["Accept"] = _SERIALIZER.header("accept", accept, "str") | ||
|
|
||
| return HttpRequest(method="DELETE", url=_url, params=_params, headers=_headers, **kwargs) | ||
| return HttpRequest(method="DELETE", url=_url, params=_params, **kwargs) |
Comment on lines
+36
to
38
| :keyword api_version: The API version to use for this operation. Known values are "2024-09-18" | ||
| and None. Default value is None. If not set, the operation's default API version will be used. | ||
| Note that overriding this default value may result in unsupported behavior. |
| { name = "Microsoft Corporation", email = "azpysdkhelp@microsoft.com" }, | ||
| ] | ||
| description = "Microsoft Azure Weightsandbiases Management Client Library for Python" | ||
| license = "MIT" |
Comment on lines
42
to
+43
| JSON = MutableMapping[str, Any] | ||
| List = list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/liftrweightsandbiases/Liftr.WeightsAndBiases.Management/tspconfig.yaml', API Version: 2024-09-18, SDK Release Type: beta, and CommitSHA: 'b373ded4a6c77a9f541ca8f020fd2072db632751' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6318761 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.