[AutoPR azure-mgmt-workloadssapvirtualinstance]-generated-from-SDK Generation - Python-6318754#46981
Open
azure-sdk wants to merge 1 commit into
Open
Conversation
….Management/tspconfig.yaml', API Version: 2024-09-01, SDK Release Type: beta, and CommitSHA: 'b373ded4a6c77a9f541ca8f020fd2072db632751' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6318754 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the azure-mgmt-workloadssapvirtualinstance Python management SDK from the latest TypeSpec/spec commit, including the new beta release packaging and regenerated client/models.
Changes:
- Migrate packaging metadata to
pyproject.toml(removesetup.py/sdk_packaging.toml) and bump version to2.0.0b1 - Regenerate operations/models with updated serialization/model-base plumbing and add
cloud_settingsupport for ARM endpoint selection - Remove previously generated sample scripts and refresh spec metadata pointers
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/tsp-location.yaml | Updates the referenced spec repo commit SHA used for generation. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/setup.py | Removes legacy setuptools setup.py packaging entrypoint. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/sdk_packaging.toml | Removes legacy packaging metadata (moved into pyproject.toml). |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/pyproject.toml | Adds PEP 621/517 packaging config and embeds [packaging] metadata. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sizing_recommendations_s4_hana_single_server.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sizing_recommendations_s4_hana_ha_av_zone.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sizing_recommendations_s4_hana_ha_av_set.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sizing_recommendations_s4_hana_distributed.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sap_supported_sku_single_server.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sap_supported_sku_distributed_ha_av_zone.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sap_supported_sku_distributed_ha_av_set.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_sap_supported_sku_distributed.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_disk_configurations_prod.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_disk_configurations_non_prod.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_availability_zone_details_northeurope.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/generated_samples/sap_virtual_instances_invoke_availability_zone_details_eastus.py | Removes generated sample script. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/operations/_patch.py | Updates patch scaffolding typing to builtin generics. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/operations/_operations.py | Regenerates sync operations layer with updated serialization/model-base imports and paging types. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/models/_patch.py | Updates patch scaffolding typing to builtin generics. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/models/_models.py | Regenerates models to use new model base and builtin generics. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/models/_enums.py | Adjusts enum member naming (S4_HANA) and minor docstring punctuation. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/aio/operations/_patch.py | Updates async patch scaffolding typing to builtin generics. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/aio/operations/_operations.py | Regenerates async operations layer with updated serialization/model-base imports and paging types. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/aio/_patch.py | Updates async patch scaffolding typing to builtin generics. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/aio/_configuration.py | Adds cloud_setting to async client configuration and updates docs. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/aio/_client.py | Adds cloud_setting + ARM endpoint discovery for async client. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_version.py | Bumps package version to 2.0.0b1. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_utils/init.py | Introduces _utils package (currently only an __init__). |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_serialization.py | Updates serialization helpers (typing, safer conversions, dict unions). |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_patch.py | Updates patch scaffolding typing to builtin generics. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_model_base.py | Major regen of shared model base (XML handling, array-encoding support, safer failsafe deserialization). |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_configuration.py | Adds cloud_setting to sync client configuration and updates docs. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/workloadssapvirtualinstance/_client.py | Adds cloud_setting + ARM endpoint discovery for sync client. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/mgmt/init.py | Adds typing ignore for namespace package path extension. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/azure/init.py | Adds typing ignore for namespace package path extension. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/apiview-properties.json | Updates APIView surface mapping and cross-language version marker. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/_metadata.json | Adds new generation metadata file. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/_meta.json | Removes legacy generation metadata file. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/README.md | Updates stated supported Python version to 3.10+. |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/MANIFEST.in | Updates packaging manifest content (metadata file removal; test/sample include tweaks). |
| sdk/workloads/azure-mgmt-workloadssapvirtualinstance/CHANGELOG.md | Adds 2.0.0b1 entry documenting cloud_setting and enum rename breaking change. |
Comment on lines
+37
to
+38
| from .._utils.model_base import SdkJSONEncoder, _deserialize, _failsafe_deserialize | ||
| from .._utils.serialization import Deserializer, Serializer |
Comment on lines
+37
to
38
| and None. Default value is None. If not set, the operation's default API version will be used. | ||
| Note that overriding this default value may result in unsupported behavior. |
| cloud_setting: Optional["AzureClouds"] = None, | ||
| **kwargs: Any | ||
| ) -> None: | ||
| api_version: str = kwargs.pop("api_version", "2024-09-01") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/workloads/Workloads.SAPVirtualInstance.Management/tspconfig.yaml', API Version: 2024-09-01, SDK Release Type: beta, and CommitSHA: 'b373ded4a6c77a9f541ca8f020fd2072db632751' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6318754 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.