Skip to content

[Identity] Fix kwarg default in DefaultAzureCredential #46073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pvaneck wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

[Identity] Fix kwarg default in DefaultAzureCredential #46073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- `DefaultAzureCredential`'s `workload_identity_client_id` keyword argument no longer inherits the value of `managed_identity_client_id`. It now independently defaults to the `AZURE_CLIENT_ID` environment variable, matching the documented behavior. ([#46073](https://github.com/Azure/azure-sdk-for-python/pull/46073))

### Other Changes

## 1.25.3 (2026-03-12)
Expand Down
4 changes: 3 additions & 1 deletion sdk/identity/azure-identity/azure/identity/_credentials/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ def __init__(self, **kwargs: Any) -> None: # pylint: disable=too-many-statement
managed_identity_client_id = kwargs.pop(
"managed_identity_client_id", os.environ.get(EnvironmentVariables.AZURE_CLIENT_ID)
)
workload_identity_client_id = kwargs.pop("workload_identity_client_id", managed_identity_client_id)
Copy link
Copy Markdown
Member

@xiangyan99 xiangyan99 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, default to managed_identity_client_id is by design.

workload_identity_client_id used to be part of managed identity.

We need to keep backward compatibility.

Copy link
Copy Markdown
Member Author

@pvaneck pvaneck Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted some thoughts here: #45900 (comment)

This coupling can lead to some surprises for the user. Do you see this as a doc only fix?

workload_identity_client_id = kwargs.pop(
"workload_identity_client_id", os.environ.get(EnvironmentVariables.AZURE_CLIENT_ID)
)
workload_identity_tenant_id = kwargs.pop(
"workload_identity_tenant_id", os.environ.get(EnvironmentVariables.AZURE_TENANT_ID)
)
Expand Down
4 changes: 3 additions & 1 deletion sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ def __init__(self, **kwargs: Any) -> None: # pylint: disable=too-many-statement
managed_identity_client_id = kwargs.pop(
"managed_identity_client_id", os.environ.get(EnvironmentVariables.AZURE_CLIENT_ID)
)
workload_identity_client_id = kwargs.pop("workload_identity_client_id", managed_identity_client_id)
workload_identity_client_id = kwargs.pop(
"workload_identity_client_id", os.environ.get(EnvironmentVariables.AZURE_CLIENT_ID)
)
workload_identity_tenant_id = kwargs.pop(
"workload_identity_tenant_id", os.environ.get(EnvironmentVariables.AZURE_TENANT_ID)
)
Expand Down