Skip to content

Conversation

@dargilco
Copy link
Member

@dargilco dargilco commented Nov 13, 2025

This is a continuation of the work done by bojunehsu in his draft PR. Paul did most of the work, here I'm adding async operations and classes, async sample code, putting code in the right location, polishing it getting ready for release. Thank you Paul!

Note that we fix emitted code to change "items_property": items to "items": items in methods search_memories and begin_update_memories. "items" is specified in TypeSpec, but Python emitter does not allow it and uses "items_property" as the JSON element in the request payload. Need to follow up on this with the emitter team.

@dargilco dargilco self-assigned this Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-ai-projects

@dargilco dargilco marked this pull request as ready for review November 14, 2025 05:59
Copilot AI review requested due to automatic review settings November 14, 2025 05:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables Memory Store operations on AIProjectClient, allowing developers to create, manage, and search conversational memories. The work continues Paul's initial implementation by adding async support, custom LRO polling, and comprehensive samples.

  • Adds CRUD operations for Memory Stores (create, read, update, delete, list)
  • Implements Memory Search Tool for agents to access past user information
  • Includes custom LRO poller classes for memory update operations (sync and async)
  • Provides comprehensive samples demonstrating memory management and agent integration
  • Fixes Python emitter issue by replacing "items_property" with "items" in generated code

Reviewed Changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
samples/memories/sample_memory_crud.py Demonstrates basic CRUD operations for memory stores (sync)
samples/memories/sample_memory_crud_async.py Demonstrates basic CRUD operations for memory stores (async)
samples/memories/sample_memory_basic.py Shows how to add and retrieve memories from a store (sync)
samples/memories/sample_memory_basic_async.py Shows how to add and retrieve memories from a store (async)
samples/memories/sample_memory_advanced.py Demonstrates advanced memory operations with chaining and context (sync)
samples/memories/sample_memory_advanced_async.py Demonstrates advanced memory operations with chaining and context (async)
samples/agents/tools/sample_agent_memory_search.py Integrates Memory Search Tool with prompt agents (sync)
samples/agents/tools/sample_agent_memory_search_async.py Integrates Memory Search Tool with prompt agents (async)
samples/agents/memory/* Removes old placeholder memory sample files
azure/ai/projects/operations/_patch_memories.py Implements custom begin_update_memories method with LRO poller (sync)
azure/ai/projects/operations/_patch.py Exports MemoryStoresOperations class (sync)
azure/ai/projects/operations/_operations.py Fixes "items_property" to "items" in generated code (sync)
azure/ai/projects/aio/operations/_patch_memories_async.py Implements custom begin_update_memories method with LRO poller (async)
azure/ai/projects/aio/operations/_patch.py Exports MemoryStoresOperations class (async)
azure/ai/projects/aio/operations/_operations.py Fixes "items_property" to "items" in generated code (async)
azure/ai/projects/models/_patch.py Implements custom LRO poller and polling method classes for memory updates
post-emitter-fixes.cmd Adds PowerShell commands to fix "items_property" issue in emitted code
README.md Documents Memory Search Tool with example code snippet
CHANGELOG.md Documents new memory store operations and samples
.env.template Adds environment variables for memory store model deployments

@dargilco dargilco merged commit 283e65a into main Nov 14, 2025
20 checks passed
@dargilco dargilco deleted the dargilco/memory-store branch November 14, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants