Skip to content

Conversation

@JennyPng
Copy link
Member

@JennyPng JennyPng commented Nov 11, 2025

@github-actions github-actions bot added the AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) label Nov 11, 2025
@JennyPng JennyPng marked this pull request as ready for review November 11, 2025 21:35
@JennyPng JennyPng requested a review from scbedd as a code owner November 11, 2025 21:35
Copilot AI review requested due to automatic review settings November 11, 2025 21:35
Copilot finished reviewing on behalf of JennyPng November 11, 2025 21:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes two issues in the CI/CD pipeline:

  • Resolves a bug in get_version_py function that was selecting the wrong _version.py file when a build directory exists
  • Adds azure-monitor-opentelemetry-exporter as a dev dependency for azure-ai-inference to fix CI analyze step failures

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sdk/ai/azure-ai-inference/dev_requirements.txt Adds relative dependency path to azure-monitor-opentelemetry-exporter to resolve CI failures
eng/tools/azure-sdk-tools/ci_tools/parsing/parse_functions.py Updates directory exclusion logic in get_version_py to skip "build" directories when searching for _version.py files

@JennyPng JennyPng requested a review from trrwilson as a code owner November 11, 2025 23:55
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run a global sdk_set_dev_version and ensure all packages properly set alpha version as they did before your change (minus the bug haha).

Then apply formatting using black. then I'll sign off!

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@JennyPng JennyPng merged commit 0e4a03b into main Nov 14, 2025
27 checks passed
@JennyPng JennyPng deleted the ai-test branch November 14, 2025 00:25
msyyc pushed a commit that referenced this pull request Nov 25, 2025
…#43947)

* sanity

* attempt fix

* try adding pre flag

* add uv case

* remove unnecessary

* add back req

* format

* refactor directory skipping

* minor doc edit

* add egg info condition

* remove doc and format

* remove tests condition since it's in exclude

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants