-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix CI Analyze Step for azure-ai-inference and get_version_py bug
#43947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two issues in the CI/CD pipeline:
- Resolves a bug in
get_version_pyfunction that was selecting the wrong_version.pyfile when abuilddirectory exists - Adds
azure-monitor-opentelemetry-exporteras a dev dependency forazure-ai-inferenceto fix CI analyze step failures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/ai/azure-ai-inference/dev_requirements.txt | Adds relative dependency path to azure-monitor-opentelemetry-exporter to resolve CI failures |
| eng/tools/azure-sdk-tools/ci_tools/parsing/parse_functions.py | Updates directory exclusion logic in get_version_py to skip "build" directories when searching for _version.py files |
scbedd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run a global sdk_set_dev_version and ensure all packages properly set alpha version as they did before your change (minus the bug haha).
Then apply formatting using black. then I'll sign off!
scbedd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
…#43947) * sanity * attempt fix * try adding pre flag * add uv case * remove unnecessary * add back req * format * refactor directory skipping * minor doc edit * add egg info condition * remove doc and format * remove tests condition since it's in exclude * format
passing nightly build for ai: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5559589&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=e3f8f308-6e5f-58aa-3a2a-fe425958de32
sdk_set_dev_version was updating the wrong
_version.pyfile for certain services (specific example:azure-monitor-opentelemetry-exporter) - fix by excluding the build directory when finding the version fileadd relative dependency to fix CI failure for
azure-ai-inference