Storage Content Validation - adding failure tests for content validation decoder#49073
Open
gunjansingh-msft wants to merge 2 commits intofeature/storage/content-validationfrom
Open
Conversation
gunjansingh-msft
requested review from
a team,
alzimmermsft,
browndav-msft,
ibrandes,
kyleknap and
seanmcc-msft
as code owners
ibrandes
changed the title
| int encodedLength = encodedData.remaining(); | ||
|
|
||
| StructuredMessageDecoder decoder = new StructuredMessageDecoder(encodedLength); | ||
| ByteBuffer result = decoder.decodeChunk(encodedData); |
Member
There was a problem hiding this comment.
nit - is possible to rename these to decodedByteBuffer? It just helps to keep track of what it is.
| private static final int SEGMENT_HEADER_LENGTH = 10; | ||
| private static final int CRC64_LENGTH = 8; | ||
|
|
||
| private static ByteBuffer collectFlux(Flux<ByteBuffer> flux) { |
Member
There was a problem hiding this comment.
nit - could we move the private methods to the bottom? It doesn't affect the functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines