[KafkaConnector]kafka pipeline fix #47782
Merged
+28
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run java - cosmos - Kafka |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
force-pushed
the
fixKafkaPipeline
branch
from
8a68cf0 to
cef3d38
Compare
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
requested review from
JonathanGiles,
alzimmermsft,
g2vinay,
rujche and
samvaity
as code owners
xinlian12
requested review from
a team,
Netyyyy,
moarychan and
saragluna
as code owners
...java/com/azure/cosmos/kafka/connect/implementation/sink/idStrategy/TemplateStrategyTest.java
Outdated
Show resolved
Hide resolved
xinlian12
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Kafka pipeline issues by ensuring Docker availability, upgrading testcontainers dependencies, and refactoring test imports to use internal implementation classes instead of testcontainers shaded dependencies.
Changes:
- Added Docker verification script to the Kafka pipeline to ensure Docker is installed and running before tests
- Upgraded testcontainers dependencies from version 1.19.5 to 1.21.4
- Refactored test imports to use Azure Cosmos internal implementation classes (Pair, assertEquals) instead of external shaded dependencies
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/kafka.yml | Added PreTestRunSteps with Docker availability check and wait logic |
| sdk/cosmos/azure-cosmos-kafka-connect/src/test/java/com/azure/cosmos/kafka/connect/implementation/sink/idStrategy/TemplateStrategyTest.java | Changed assertion import from JUnit to TestNG AssertJUnit for consistency |
| sdk/cosmos/azure-cosmos-kafka-connect/src/test/java/com/azure/cosmos/kafka/connect/CosmosSourceConnectorTest.java | Changed Pair import from testcontainers shaded to cosmos implementation package |
| sdk/cosmos/azure-cosmos-kafka-connect/src/test/java/com/azure/cosmos/kafka/connect/CosmosSinkConnectorTest.java | Changed Pair import from testcontainers shaded to cosmos implementation package |
| sdk/cosmos/azure-cosmos-kafka-connect/pom.xml | Updated testcontainers and kafka testcontainers dependencies to version 1.21.4 |
| eng/versioning/external_dependencies.txt | Updated testcontainers dependency versions to match pom.xml changes |
Member
Author
|
/azp run java - cosmos - kafka |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tvaron3
approved these changes
Jan 23, 2026
Member
Author
|
/check-enforcer override |
alzimmermsft
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Kafka pipeline failed with "can not find valid docker environment"
Fix
Upgrade TestContainer version