-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Internal / Gateway V 2_0 / DO NOT MERGE]: Route Execute Stored Procedure requests to Gateway V2 endpoint. #47756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Internal / Gateway V 2_0 / DO NOT MERGE]: Route Execute Stored Procedure requests to Gateway V2 endpoint. #47756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables Execute Stored Procedure requests to be routed to the Gateway V2 endpoint (thin client) by adding support for stored procedure operations alongside existing document operations in the thin client routing logic.
Changes:
- Added a helper method to identify stored procedure execution requests
- Updated thin client routing logic to include stored procedure executions
- Added comprehensive E2E test coverage for stored procedure execution via thin client
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentServiceRequest.java | Added isExecuteStoredProcedureBasedRequest() helper method to identify stored procedure execution requests |
| sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java | Updated useThinClientStoreModel() to allow thin client routing for stored procedure executions |
| sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/ThinClientE2ETest.java | Added comprehensive E2E test testThinClientStoredProcedure() to validate stored procedure execution through thin client endpoint |
| System.setProperty("COSMOS.THINCLIENT_ENABLED", "true"); | ||
| System.setProperty("COSMOS.HTTP2_ENABLED", "true"); |
Copilot
AI
Jan 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The System.setProperty calls on lines 387-388 should be commented out to match the pattern used in all other tests in this file. These properties are meant to be set via environment configuration during test execution, not hardcoded in the test. Please comment out these lines like in the other test methods.
| System.setProperty("COSMOS.THINCLIENT_ENABLED", "true"); | |
| System.setProperty("COSMOS.HTTP2_ENABLED", "true"); | |
| // System.setProperty("COSMOS.THINCLIENT_ENABLED", "true"); | |
| // System.setProperty("COSMOS.HTTP2_ENABLED", "true"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
| } | ||
| } | ||
|
|
||
| @Test(groups = {"thinclient"}, retryAnalyzer = FlakyTestRetryAnalyzer.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the FlakyTestRetryAnalyzer really needed for this simple test?
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
Description
As title.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines