Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Azure Databricks PowerShell module from API version 2024-05-01 to 2026-01-01. The primary functional change is the addition of a new ComputeMode parameter to the New-AzDatabricksWorkspace cmdlet, which allows users to specify 'Hybrid' or 'Serverless' compute modes when creating workspaces.
Changes:
- API version upgraded from 2024-05-01 to 2026-01-01 across all module components
- Added ComputeMode parameter (Hybrid/Serverless) to workspace creation
- Updated all API model references from Api20240501 to Api202601
- Enhanced test coverage with new scenarios for Serverless and Enhanced Security Compliance (ESC) workspaces
- Updated test infrastructure with second resource group and cleanup logic
Reviewed changes
Copilot reviewed 30 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Databricks/Databricks/ChangeLog.md | Added entry for ComputeMode parameter support |
| src/Databricks/Databricks/help/New-AzDatabricksWorkspace.md | Added documentation for ComputeMode parameter |
| src/Databricks/Databricks.Autorest/README.md | Updated API version commit hash and module version |
| src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspace.ps1 | Implemented ComputeMode logic with default to 'Hybrid' |
| src/Databricks/Databricks.Autorest/custom/Update-AzDatabricksWorkspace.ps1 | Updated API model references and breaking change attributes |
| src/Databricks/Databricks.Autorest/custom/Update-AzDatabricksVNetPeering.ps1 | Updated API model references |
| src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspaceProviderAuthorizationObject.ps1 | Updated API model references |
| src/Databricks/Databricks.Autorest/test/AzDatabricksWorkspace.Tests.ps1 | Added Serverless and ESC test scenarios, commented out OutboundNetworkDependencies test |
| src/Databricks/Databricks.Autorest/test/AzDatabricksVNetPeering.Tests.ps1 | Added -NoWait to cleanup operation |
| src/Databricks/Databricks.Autorest/test/utils.ps1 | Added second resource group setup and enabled cleanup |
| src/Databricks/Databricks.Autorest/test/env.json, localEnv.json | Added test environment variables |
| src/Databricks/Databricks.Autorest/test/AzDatabricksVNetPeering.Recording.json | Updated test recordings with new API version |
| src/Databricks/Databricks.Autorest/Properties/AssemblyInfo.cs | Updated assembly version (though inconsistent with README) |
| src/Databricks/Databricks.Autorest/docs/*.md | Updated all help documentation with new API model references |
| src/Databricks/Databricks.Autorest/UX/*.json | Updated API versions in UX configuration |
| src/Databricks/Databricks.Autorest/generate-info.json | Deleted (normal for regeneration) |
src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspace.ps1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/Databricks/Databricks.Autorest/custom/Update-AzDatabricksWorkspace.ps1
Outdated
Show resolved
Hide resolved
src/Databricks/Databricks.Autorest/custom/Update-AzDatabricksVNetPeering.ps1
Outdated
Show resolved
Hide resolved
src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspace.ps1
Outdated
Show resolved
Hide resolved
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Databricks", "Databricks\Databricks.csproj", "{78057EB6-1C85-4118-94B4-8021CCD6902E}" | ||
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Databricks.Autorest", "Databricks.Autorest", "{5FE84A12-8651-7F44-066E-17161CDB0E9D}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Az.Databricks", "..\..\generated\Databricks\Databricks.Autorest\Az.Databricks.csproj", "{2B4B9E93-9F35-499A-905E-1DA5210E71A7}" | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Az.Databricks", "Databricks.Autorest\Az.Databricks.csproj", "{CD4F8633-C856-4A59-808E-8B50705F6E26}" | ||
| EndProject |
There was a problem hiding this comment.
The solution now references Databricks.Autorest\Az.Databricks.csproj, but there is no Az.Databricks.csproj under src/Databricks/Databricks.Autorest/ in the repo. This will break opening/building the Databricks solution. Update the path to the actual project location (currently under generated/Databricks/Databricks.Autorest/) or add/move the csproj so the reference resolves.
There was a problem hiding this comment.
@isra-fel Is this an issue? This isn't something I changed manually
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
isra-fel
left a comment
There was a problem hiding this comment.
Please see my comments inline. Thanks
src/Databricks/Databricks.Autorest/custom/New-AzDatabricksWorkspace.ps1
Outdated
Show resolved
Hide resolved
|
|
||
| ```yaml | ||
| Type: Microsoft.Azure.PowerShell.Cmdlets.Databricks.Support.ComplianceStandard[] | ||
| Type: System.String[] |
There was a problem hiding this comment.
This breaking change (Enum to string) should have been part of autorest.powershell v4 but Databricks is actually still on v3. I don't understand why. @VeryEarly what's your opinion here?
There was a problem hiding this comment.
We don't want to update to autorest v4 yet, will do after this PR.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
b1cef08 to
20f9e5e
Compare
| [OutputType([Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20240501.IWorkspace])] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Runtime.OutputBreakingChangeAttribute("Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20240501.IWorkspace", "16.0.0", "2.0.0", "May 2026", ReplacementCmdletOutputType = "Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IWorkspace", DeprecatedOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization"), NewOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization The types of the properties will be changed from object to 'List'"))] | ||
| [OutputType([Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api202601.IWorkspace])] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Runtime.OutputBreakingChangeAttribute("Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api202601.IWorkspace", "16.0.0", "2.0.0", "May 2026", ReplacementCmdletOutputType = "Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IWorkspace", DeprecatedOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization"), NewOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization The types of the properties will be changed from object to 'List'"))] |
There was a problem hiding this comment.
The breaking change date format "May 2026" does not follow the required "YYYY/MM/DD" format. According to repository conventions, breaking change attributes should use a specific date format like "2026/05/01" rather than text-based formats like "May 2026". This format is required for automated processing of breaking change announcements.
There was a problem hiding this comment.
This change was done by the powershell team
| [OutputType([Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20240501.IWorkspace])] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Runtime.OutputBreakingChangeAttribute("Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20240501.IWorkspace", "16.0.0", "2.0.0", "May 2026", ReplacementCmdletOutputType = "Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IWorkspace", DeprecatedOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization"), NewOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization The types of the properties will be changed from object to 'List'"))] | ||
| [OutputType([Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api202601.IWorkspace])] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Runtime.OutputBreakingChangeAttribute("Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api202601.IWorkspace", "16.0.0", "2.0.0", "May 2026", ReplacementCmdletOutputType = "Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IWorkspace", DeprecatedOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization"), NewOutputProperties = ("PrivateEndpointConnection, ComplianceSecurityProfileComplianceStandard, Authorization The types of the properties will be changed from object to 'List'"))] |
There was a problem hiding this comment.
The breaking change date format "May 2026" does not follow the required "YYYY/MM/DD" format. According to repository conventions, breaking change attributes should use a specific date format like "2026/05/01" rather than text-based formats like "May 2026". This format is required for automated processing of breaking change announcements.
| [OutputType([Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20240501.IVirtualNetworkPeering])] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Runtime.OutputBreakingChangeAttribute("Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api20240501.IVirtualNetworkPeering", "16.0.0", "2.0.0", "May 2026", ReplacementCmdletOutputType = "Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IVirtualNetworkPeering", DeprecatedOutputProperties = ("DatabrickAddressSpaceAddressPrefix, RemoteAddressSpaceAddressPrefix 'System.String[]'"), NewOutputProperties = ("DatabrickAddressSpaceAddressPrefix, RemoteAddressSpaceAddressPrefix 'System.Collections.Generic.List`1[System.String]'"))] | ||
| [OutputType([Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api202601.IVirtualNetworkPeering])] | ||
| [Microsoft.Azure.PowerShell.Cmdlets.Databricks.Runtime.OutputBreakingChangeAttribute("Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.Api202601.IVirtualNetworkPeering", "16.0.0", "2.0.0", "May 2026", ReplacementCmdletOutputType = "Microsoft.Azure.PowerShell.Cmdlets.Databricks.Models.IVirtualNetworkPeering", DeprecatedOutputProperties = ("DatabrickAddressSpaceAddressPrefix, RemoteAddressSpaceAddressPrefix 'System.String[]'"), NewOutputProperties = ("DatabrickAddressSpaceAddressPrefix, RemoteAddressSpaceAddressPrefix 'System.Collections.Generic.List`1[System.String]'"))] |
There was a problem hiding this comment.
The breaking change date format "May 2026" does not follow the required "YYYY/MM/DD" format. According to repository conventions, breaking change attributes should use a specific date format like "2026/05/01" rather than text-based formats like "May 2026". This format is required for automated processing of breaking change announcements.
src/Databricks/Databricks.Autorest/docs/New-AzDatabricksWorkspace.md
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.