[BodyTopLevelProperties] Add "managedByExtended" to allowed list of top-level properties#810
[BodyTopLevelProperties] Add "managedByExtended" to allowed list of top-level properties#810
Conversation
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
There was a problem hiding this comment.
@copilot instead of creating a new json file for the test , can you just update one of the existing files to include these tests ?
There was a problem hiding this comment.
Updated! I've added the managedByExtended property to the existing body-top-level-properties-real-swagger.json file instead of creating a new test file. The separate test file has been removed and the test case now uses the updated existing file. All tests pass. (commit 90d4543)
…tended Co-authored-by: raosuhas <11067581+raosuhas@users.noreply.github.com>
|
@copilot: update the package.json and changelog associated with this package |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
@copilot: Actually, we directly update package.json and readme.md now, instead of using rush. See PR #783 as an example. For this PR, bump the patch version by one. |
@copilot: Why did you think you needed to use Rush to update this? Was it some documentation in the repo? |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Updated! Removed the Rush change file and directly updated package.json (bumped version from 2.2.0 to 2.2.1) and CHANGELOG.md with the new patch version entry. (commit 5cb9e21) |
Yes, the CONTRIBUTING.md documentation (lines 105-107) instructs to "Run |
|
@copilot: increment the patch version by one |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
|
@copilot: increment the patch version by one again |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Summary
Added
managedByExtendedto the list of allowed body top-level properties for ARM resources in compliance with ARM guidelines.Changes Made
Code Changes
allowedBodyTopLevelPropertiesarray in arm-resource-validation.ts to includemanagedbyextendedpropertiesBagTrackedarray in arm-resource-validation.ts to includemanagedbyextendedDocumentation Changes
Testing
body-top-level-properties-real-swagger.jsonto include managedByExtended propertyPackage Management
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.