Create staging lint checks workflow#785
Merged
AkhilaIlla merged 107 commits intomainfrom Oct 31, 2025
Merged
Conversation
…eline_for-_linter_rules
… into akhilailla/add_workflow_to_simulate_test_pipeline_for-_linter_rules
danieljurek
reviewed
Sep 4, 2025
Member
danieljurek
left a comment
There was a problem hiding this comment.
This PR is moving things in the right direction. I have a few questions about how rules are evaluated and whether there's a way to infer what to check instead of relying on the user to supply that data.
mikeharder
reviewed
Sep 5, 2025
mikeharder
reviewed
Sep 5, 2025
mikeharder
reviewed
Sep 5, 2025
mikeharder
reviewed
Sep 5, 2025
mikeharder
reviewed
Sep 5, 2025
mikeharder
reviewed
Sep 5, 2025
mikeharder
reviewed
Sep 5, 2025
Member
|
@AkhilaIlla: @danieljurek and I were discussing, and we think this might work better if we put the workflow in the specs repo instead. It would work like this:
This has several benefits:
I can create a skeleton WF in the specs repo to help get you started. My start on a WF in specs repo to test aov: Azure/azure-rest-api-specs#37180 #Resolved |
added 7 commits
October 7, 2025 11:27
…ets package not installed
- Should probably use vitest env mocking instead
…eline_for-_linter_rules
mikeharder
reviewed
Oct 29, 2025
mikeharder
approved these changes
Oct 30, 2025
mikeharder
reviewed
Oct 30, 2025
mikeharder
reviewed
Oct 30, 2025
…linter_rules' of https://github.com/Azure/azure-openapi-validator into akhilailla/add_workflow_to_simulate_test_pipeline_for-_linter_rules
mikeharder
approved these changes
Oct 31, 2025
mikeharder
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a workflow to validate linter rules that are under development. It ensures these rules are tested against the specifications, allowing us to build confidence in them before merging and releasing to production.
How the staging-lint-checks workflow runs selected rules
Root workflow: staging-lint-checks.yaml
Triggers: pull_request events (opened, edited, synchronize, labeled, unlabeled)
Flow:
Checks out this repo and sets up Node 18
Derives RULE_NAMES from PR labels (test-) or a “rules: A,B” line in the PR body
Checks out azure-rest-api-specs into specs/
Installs minimal deps for the runner
Runs the script run-selected-rules.js with env:
RULE_NAMES, SPEC_ROOT=specs/, FAIL_ON_ERRORS, OUTPUT_FILE
The runner filters to JSON under specification/
Rules:PutResponseCodes
Latest workflow run: https://github.com/Azure/azure-openapi-validator/actions/runs/18791474287/job/53622542134
Output:
linter-findings.txt