Draft
Conversation
added 8 commits
November 9, 2022 17:33
rkmanda
reviewed
Dec 22, 2022
| return false; | ||
| } | ||
|
|
||
| export function createRuleFunctionWithPasses<I = unknown, O = unknown>(fn:(input:I, options:O, ctx: RulesetFunctionContext)=> IFunctionResult[]) { |
Member
rkmanda
reviewed
Dec 22, 2022
| const messsages = fn(input,options,ctx) | ||
| if (messsages.length === 0) { | ||
| messsages.push({ | ||
| message: `[Verbose]this is a verbose message to indicate that this rule was passed for specific swagger schema successfully and no fix is needed, please ignore it.`, |
Member
Contributor
Author
There was a problem hiding this comment.
The path is another field of the error object, I think we don't need to duplicate it in the message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #421
after the PR, the message will contain 'details.providerNamespace' and 'details.resourceType' fields when the jsonpath contains a swagger path
{ "pluginName": "spectral", "extensionName": "@microsoft.azure/openapi-validator", "level": "warning", "message": "The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.", "code": "XmsLongRunningOperationOptions", "details": { "jsonpath": [ "paths", "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/containerApps/{containerAppName}", "put" ], "providerNamespace": "Microsoft.App", "resourceType": "containerApps", "range": { "start": { "line": 148, "column": 12 }, "end": { "line": 210, "column": 43 } } }, "source": [ { "document": "specification/app/resource-manager/Microsoft.App/preview/2022-11-01-preview/ContainerApps.json", "position": { "line": 148, "column": 7 } } ] }And the verbose message would like