Skip to content

Conversation

@tanmaya-panda1
Copy link
Collaborator

This pull request adds comprehensive unit tests for key components in the ingest-v2 module, focusing on batch operation results, retry policy logic, and managed streaming policy behavior. Additionally, it includes a minor parameter ordering fix for the FileSource constructor to improve consistency.

New and Improved Unit Tests:

  • Added unit tests for the BatchOperationResult interface and its implementations, including UploadResults, covering scenarios for successes, failures, and total count calculations (BatchOperationResultTest.kt).
  • Introduced tests for retry policy classes, verifying the behavior of NoRetryPolicy, SimpleRetryPolicy, CustomRetryPolicy, and the Retry data class (RetryPolicyTest.kt).
  • Provided thorough tests for managed streaming policy classes, covering error categories, request success/failure details, and the logic in DefaultManagedStreamingPolicy (including error tracking and retry policy creation) (ManagedStreamingPolicyTest.kt).

Code Quality Improvements:

  • Standardized the constructor parameter order for FileSource to have compressionType before sourceId, and updated usage in related tests for consistency (FileSource.kt, ManagedStreamingIngestClientJavaTest.java, QueuedIngestClientJavaTest.java). [1] [2] [3]### Added

Changed

Fixed

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

Test Results

530 tests  ±0   521 ✅ ±0   3m 7s ⏱️ -13s
 31 suites ±0     9 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 791bbce. ± Comparison against base commit bca955e.

♻️ This comment has been updated with latest results.

@ag-ramachandran ag-ramachandran merged commit d6a66f7 into feature/IngestV2 Jan 8, 2026
9 of 17 checks passed
@ag-ramachandran ag-ramachandran deleted the feature/add-junits branch January 8, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants