-
Notifications
You must be signed in to change notification settings - Fork 44
Feature/add junits #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/add junits #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dcff2d to
bca955e
Compare
3581ae5 to
791bbce
Compare
ag-ramachandran
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive unit tests for key components in the ingest-v2 module, focusing on batch operation results, retry policy logic, and managed streaming policy behavior. Additionally, it includes a minor parameter ordering fix for the
FileSourceconstructor to improve consistency.New and Improved Unit Tests:
BatchOperationResultinterface and its implementations, includingUploadResults, covering scenarios for successes, failures, and total count calculations (BatchOperationResultTest.kt).NoRetryPolicy,SimpleRetryPolicy,CustomRetryPolicy, and theRetrydata class (RetryPolicyTest.kt).DefaultManagedStreamingPolicy(including error tracking and retry policy creation) (ManagedStreamingPolicyTest.kt).Code Quality Improvements:
FileSourceto havecompressionTypebeforesourceId, and updated usage in related tests for consistency (FileSource.kt,ManagedStreamingIngestClientJavaTest.java,QueuedIngestClientJavaTest.java). [1] [2] [3]### AddedChanged
Fixed