Remove vavr and resilience4j dependencies #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We’re noticing a few exceptions when using the latest resilience4j versions due to incompatibility between Java 17+ and the 1.7.1 version currently used in Kusto. Since 1.7.1 is quite old, I think we could remove it entirely and instead use the Reactor retry logic we implemented during the async refactor. This would make the codebase more compatible with newer Java versions. Let me know what you guys think. |
georgebanasios
force-pushed
the
remove-vavr
branch
from
845963d to
1eb6dea
Compare
Contributor
|
Generally looks good, but it is technically breaking since the Util methods were public.. But I don't think they are an actual part of the API. I'll discuss with @yogilad |
Contributor
|
Discussed - Utils aren't really part of the public API, I'll make a note about it in the next release. |
AsafMah
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes vavr and resilience4j dependencies.