[Compute] Fix #33556: az vm boot-diagnostics get-boot-log: Fix TypeError with azure-mgmt-storage 25.0.0

[Pavel Dostál (pdostal)]

Related command
az vm boot-diagnostics get-boot-log

Description
Fixes #33556. StorageAccountListKeysResult in azure-mgmt-storage 25.0.0 now inherits from MutableMapping, so .keys resolves to the built-in dict.keys method instead of the renamed keys_property list. This crashed get_boot_log with TypeError: 'method' object is not subscriptable when a VM uses a custom (non-managed) storage account for boot diagnostics. Also fixes the same pattern in the unused _get_private_config helper.

Related to #33727, which addresses the same root cause but additionally adds a keys_property/keys fallback for older azure-mgmt-storage versions and touches batchai/custom.py. Since this repo pins azure-mgmt-storage==25.0.0 exactly (see src/azure-cli/setup.py), that fallback isn't functionally required here, so this PR keeps the fix minimal and scoped to the actual regression.

Testing Guide

# Unit test (no live resources needed)
python -m pytest src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_custom_vm_commands.py -k BootLog -v

# Live smoke-test (VM must use a custom storage account for boot diagnostics)
az vm boot-diagnostics get-boot-log --resource-group <rg> --name <vm-name>

History Notes
[Compute] az vm boot-diagnostics get-boot-log: Fix TypeError: 'method' object is not subscriptable when VM uses a custom storage account for boot diagnostics (regression with azure-mgmt-storage 25.0.0)

---

• The PR title and description has followed the guideline in Submitting Pull Requests.
• I adhere to the Command Guidelines.
• I adhere to the Error Handling Guidelines.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[microsoft-github-policy-service]

Thank you for your contribution Pavel Dostál (@pdostal)! We will review the pull request and get back to you soon.

[Copilot]

Pull request overview

Fixes a regression in az vm boot-diagnostics get-boot-log caused by azure-mgmt-storage==25.0.0 changing StorageAccountListKeysResult so that .keys resolves to the mapping method instead of the key list, leading to TypeError: 'method' object is not subscriptable for VMs using a custom boot diagnostics storage account.

Changes:

• Update VM boot log retrieval to use keys_property instead of keys when reading storage account keys.
• Apply the same fix in the _get_private_config helper.
• Add a unit test asserting keys_property is used to construct the BlobClient credential.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/azure-cli/azure/cli/command_modules/vm/custom.py	Switch storage key access from .keys to .keys_property for list_keys results to avoid the MutableMapping .keys() collision.
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_custom_vm_commands.py	Add regression unit test validating the boot log path uses keys_property when building the blob client credential.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Pavel Dostál (pdostal)]

Hello Teresa Ritorto (@teresaritorto), can you please advice me if this fix makes sense and who should help me to review it? I'm willing to work on it but I can also drop it in favor of #33727.