Skip to content

{Resource} Fix CredScan sanitize hardcoded storage account key in test recording #33656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YangAn-microsoft wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

{Resource} Fix CredScan sanitize hardcoded storage account key in test recording #33656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../command_modules/resource/tests/latest/recordings/test_resource_show_built_in_policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40071,7 +40071,7 @@ interactions:
-File bin\\\\myCustomScriptDeployService.ps1\"},\"myStorageAccountName\":{\"type\":\"String\",\"metadata\":{\"displayName\":\"storageAccountName\",\"description\":null},\"defaultValue\":\"mystorageaccountev2test1\"},\"myStorageAccountKey\":{\"type\":\"String\",\"metadata\":{\"displayName\":\"storageAccountKey\",\"description\":null},\"defaultValue\":\"\"}},\"policyRule\":{\"if\":{\"allOf\":[{\"field\":\"type\",\"equals\":\"Microsoft.Compute/virtualMachineScaleSets\"},{\"field\":\"Microsoft.Compute/imagePublisher\",\"equals\":\"MicrosoftWindowsServer\"},{\"field\":\"Microsoft.Compute/imageOffer\",\"equals\":\"WindowsServer\"},{\"field\":\"[concat('tags[',
parameters('skipTagName'), ']')]\",\"exists\":\"false\"},{\"value\":\"[contains(resourceGroup().tags,
parameters('skipTagName'))]\",\"equals\":\"false\"},{\"value\":\"[contains(subscription().tags,
parameters('skipTagName'))]\",\"equals\":\"false\"}]},\"then\":{\"effect\":\"[parameters('effect')]\",\"details\":{\"type\":\"Microsoft.Compute/virtualMachineScaleSets/extensions\",\"existenceCondition\":{\"allOf\":[{\"field\":\"Microsoft.Compute/virtualMachineScaleSets/extensions/type\",\"equals\":\"CustomScriptExtension\"},{\"field\":\"Microsoft.Compute/virtualMachineScaleSets/extensions/publisher\",\"equals\":\"Microsoft.Compute\"}]},\"roleDefinitionIds\":[\"/providers/microsoft.authorization/roleDefinitions/9980e02c-c2be-4d73-94e8-173b1dc7cf3c\"],\"deployment\":{\"properties\":{\"mode\":\"incremental\",\"template\":{\"$schema\":\"http://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\"contentVersion\":\"1.0.0.0\",\"parameters\":{\"vmssName\":{\"type\":\"string\"},\"vmsslocation\":{\"type\":\"string\"},\"autoUpgradeMinorVersionBool\":{\"type\":\"string\"},\"timestamp\":{\"type\":\"string\"},\"myServicePackage\":{\"type\":\"string\"},\"myDeploymentScript\":{\"type\":\"string\"},\"commandToExecute\":{\"type\":\"string\"},\"myStorageAccountName\":{\"type\":\"string\"},\"myStorageAccountKey\":{\"type\":\"string\"}},\"variables\":{},\"resources\":[{\"type\":\"Microsoft.Compute/virtualMachineScaleSets/extensions\",\"apiVersion\":\"2022-03-01\",\"name\":\"[concat(parameters('vmssName'),'/CustomScriptExtension')]\",\"location\":\"[parameters('vmsslocation')]\",\"properties\":{\"publisher\":\"Microsoft.Compute\",\"type\":\"CustomScriptExtension\",\"typeHandlerVersion\":\"1.9\",\"autoUpgradeMinorVersion\":\"[parameters('autoUpgradeMinorVersionBool')]\",\"settings\":{\"timestamp\":\"[parameters('timestamp')]\"},\"protectedSettings\":{\"fileUris\":[\"[parameters('myServicePackage')]\",\"[parameters('myDeploymentScript')]\"],\"commandToExecute\":\"[parameters('commandToExecute')]\",\"storageAccountName\":\"[parameters('myStorageAccountName')]\",\"storageAccountKey\":\"L7xWx2++8AeTjEpiNU9xJ0UFUS0qgf58NwOy2pOocFKNaVUcJswD/VosztdBr3lG3doSseXMk0iE+AStDELmnw==\"}}}]},\"parameters\":{\"vmssName\":{\"value\":\"[field('name')]\"},\"vmsslocation\":{\"value\":\"[field('location')]\"},\"autoUpgradeMinorVersionBool\":{\"value\":\"[parameters('autoUpgradeMinorVersionBool')]\"},\"timestamp\":{\"value\":\"[parameters('timestamp')]\"},\"myStorageAccountName\":{\"value\":\"[parameters('myStorageAccountName')]\"},\"myStorageAccountKey\":{\"value\":\"[parameters('myStorageAccountKey')]\"},\"myServicePackage\":{\"value\":\"[parameters('myServicePackage')]\"},\"myDeploymentScript\":{\"value\":\"[parameters('myDeploymentScript')]\"},\"commandToExecute\":{\"value\":\"[parameters('commandToExecute')]\"}}}}}}},\"versions\":[\"1.0.0\"]},\"id\":\"/providers/Microsoft.Management/managementGroups/AzGovPerfTest/providers/Microsoft.Authorization/policyDefinitions/EV2Example-DINE-VMSS\",\"type\":\"Microsoft.Authorization/policyDefinitions\",\"name\":\"EV2Example-DINE-VMSS\",\"systemData\":{\"createdBy\":\"test@example.com\",\"createdByType\":\"User\",\"createdAt\":\"2022-10-20T00:05:46.7845637Z\",\"lastModifiedBy\":\"test@example.com\",\"lastModifiedByType\":\"User\",\"lastModifiedAt\":\"2022-10-20T17:51:11.1158285Z\"}},{\"properties\":{\"displayName\":\"Example
parameters('skipTagName'))]\",\"equals\":\"false\"}]},\"then\":{\"effect\":\"[parameters('effect')]\",\"details\":{\"type\":\"Microsoft.Compute/virtualMachineScaleSets/extensions\",\"existenceCondition\":{\"allOf\":[{\"field\":\"Microsoft.Compute/virtualMachineScaleSets/extensions/type\",\"equals\":\"CustomScriptExtension\"},{\"field\":\"Microsoft.Compute/virtualMachineScaleSets/extensions/publisher\",\"equals\":\"Microsoft.Compute\"}]},\"roleDefinitionIds\":[\"/providers/microsoft.authorization/roleDefinitions/9980e02c-c2be-4d73-94e8-173b1dc7cf3c\"],\"deployment\":{\"properties\":{\"mode\":\"incremental\",\"template\":{\"$schema\":\"http://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\"contentVersion\":\"1.0.0.0\",\"parameters\":{\"vmssName\":{\"type\":\"string\"},\"vmsslocation\":{\"type\":\"string\"},\"autoUpgradeMinorVersionBool\":{\"type\":\"string\"},\"timestamp\":{\"type\":\"string\"},\"myServicePackage\":{\"type\":\"string\"},\"myDeploymentScript\":{\"type\":\"string\"},\"commandToExecute\":{\"type\":\"string\"},\"myStorageAccountName\":{\"type\":\"string\"},\"myStorageAccountKey\":{\"type\":\"string\"}},\"variables\":{},\"resources\":[{\"type\":\"Microsoft.Compute/virtualMachineScaleSets/extensions\",\"apiVersion\":\"2022-03-01\",\"name\":\"[concat(parameters('vmssName'),'/CustomScriptExtension')]\",\"location\":\"[parameters('vmsslocation')]\",\"properties\":{\"publisher\":\"Microsoft.Compute\",\"type\":\"CustomScriptExtension\",\"typeHandlerVersion\":\"1.9\",\"autoUpgradeMinorVersion\":\"[parameters('autoUpgradeMinorVersionBool')]\",\"settings\":{\"timestamp\":\"[parameters('timestamp')]\"},\"protectedSettings\":{\"fileUris\":[\"[parameters('myServicePackage')]\",\"[parameters('myDeploymentScript')]\"],\"commandToExecute\":\"[parameters('commandToExecute')]\",\"storageAccountName\":\"[parameters('myStorageAccountName')]\",\"storageAccountKey\":\"veryFakedStorageAccountKey==\"}}}]},\"parameters\":{\"vmssName\":{\"value\":\"[field('name')]\"},\"vmsslocation\":{\"value\":\"[field('location')]\"},\"autoUpgradeMinorVersionBool\":{\"value\":\"[parameters('autoUpgradeMinorVersionBool')]\"},\"timestamp\":{\"value\":\"[parameters('timestamp')]\"},\"myStorageAccountName\":{\"value\":\"[parameters('myStorageAccountName')]\"},\"myStorageAccountKey\":{\"value\":\"[parameters('myStorageAccountKey')]\"},\"myServicePackage\":{\"value\":\"[parameters('myServicePackage')]\"},\"myDeploymentScript\":{\"value\":\"[parameters('myDeploymentScript')]\"},\"commandToExecute\":{\"value\":\"[parameters('commandToExecute')]\"}}}}}}},\"versions\":[\"1.0.0\"]},\"id\":\"/providers/Microsoft.Management/managementGroups/AzGovPerfTest/providers/Microsoft.Authorization/policyDefinitions/EV2Example-DINE-VMSS\",\"type\":\"Microsoft.Authorization/policyDefinitions\",\"name\":\"EV2Example-DINE-VMSS\",\"systemData\":{\"createdBy\":\"test@example.com\",\"createdByType\":\"User\",\"createdAt\":\"2022-10-20T00:05:46.7845637Z\",\"lastModifiedBy\":\"test@example.com\",\"lastModifiedByType\":\"User\",\"lastModifiedAt\":\"2022-10-20T17:51:11.1158285Z\"}},{\"properties\":{\"displayName\":\"Example
DINE policy to deploy VMSS custom extension\",\"policyType\":\"Custom\",\"mode\":\"Indexed\",\"description\":\"Example
DINE policy to deploy VMSS custom extension.\",\"metadata\":{\"createdBy\":\"327c26bf-bf3e-4128-9b75-fbbd99e98739\",\"createdOn\":\"2022-10-24T06:28:23.3964914Z\",\"updatedBy\":\"327c26bf-bf3e-4128-9b75-fbbd99e98739\",\"updatedOn\":\"2022-10-25T20:07:34.275501Z\"},\"version\":\"1.0.0\",\"parameters\":{\"effect\":{\"type\":\"String\",\"metadata\":{\"displayName\":\"Effect\",\"description\":\"Enable
or disable the execution of the policy\"},\"allowedValues\":[\"DeployIfNotExists\",\"Disabled\"],\"defaultValue\":\"DeployIfNotExists\"},\"skipTagName\":{\"type\":\"String\",\"metadata\":{\"displayName\":\"Exclusion
Expand Down
Loading