[Event Hubs] Fix #32073: az eventhubs eventhub list: Prevent namespace name validation regression#33636
[Event Hubs] Fix #32073: az eventhubs eventhub list: Prevent namespace name validation regression#33636Copilot wants to merge 8 commits into
az eventhubs eventhub list: Prevent namespace name validation regression#33636Conversation
️✔️AzureCLI-FullTest
|
|
Hi @copilot, |
️✔️AzureCLI-BreakingChangeTest
|
az eventhubs eventhub list: Prevent namespace name validation regression
Live test results —
|
azclibot
left a comment
There was a problem hiding this comment.
CI Failure — Action Required
One CI check has failed for this PR:
| Check | Result | Details |
|---|---|---|
| Credential Scanner | ❌ Failed | View run |
Credential Scanner scans the code for accidentally committed secrets, tokens, or credentials. Please review the failed run to see which file(s) triggered the scan, and either remove or redact any detected sensitive strings.
Note: 3 other checks (
Check CLI Linter,Check CLI Style, and a package build) have been pending for over 3 hours and appear stuck. These can be ignored for now — only the Credential Scanner failure blocks this PR. Once you address that, re-push and CI will re-run.
Posted by agent-assist (autonomous bug-fix pipeline).
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33636 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
Addressed in I investigated the Credential Scanner failure and it was flagging base64-looking Basic auth placeholders in |
Live test results —
|
azclibot
left a comment
There was a problem hiding this comment.
CI Failure: Codegen Coverage
One CI check failed on this PR:
| Check | Status |
|---|---|
| Azure.azure-cli (Codegen Coverage) | ❌ FAILED |
Codegen Coverage – This check verifies that any CLI commands/parameters introduced or modified in this PR are properly reflected in the codegen coverage tracking (output titles, descriptions, and parameter schemas must align with what the code generator produces).
What to do:
- Review the Codegen Coverage check for details on what specifically failed.
- Ensure that any changes to argument definitions, validators, or schema properties in
eventhubsmatch the expected generated output. - Run
azdev styleandazdev linterlocally to catch any additional issues before pushing.
The live-test workflow completed successfully ✅ — no functional regressions were detected.
Please fix the Codegen Coverage failure and push an updated commit.
Posted by agent-assist (autonomous bug-fix pipeline).
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33636 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
Addressed in I kept the regression coverage intact and made the new Event Hubs validation test defer its private AAZ |
Live test results —
|
azclibot
left a comment
There was a problem hiding this comment.
CI Failure: Codegen Coverage
The live-test workflow completed with success ✅, but one CI check has failed:
| Check | Result |
|---|---|
| Azure.azure-cli (Codegen Coverage) | ❌ FAILED (1 error) |
Codegen Coverage checks that all CLI commands have corresponding codegen/swagger coverage entries. This failure may indicate that the new test file references commands that are missing from the codegen coverage map, or there is a pre-existing issue that was surfaced. Please investigate the Codegen Coverage check run and fix any coverage gaps introduced or uncovered by this PR.
All other completed checks passed. Please address the Codegen Coverage failure and push a new commit.
PR title & description format (required)
This repo enforces a PR format (guide). Please author the PR exactly as follows or CI's Check the Format of Pull Request Title and Content will fail.
Title
- Start with
[Event Hubs]— square brackets[]for a customer-facing change (added toHISTORY.rst), curly{}if not. A bug fix is customer-facing, so use[]. - Then
Fix #32073:to link the issue (use the short#Nform, notowner/repo#N). - Then the affected command wrapped in backticks followed by a colon — e.g.
`az vm create`:.⚠️ The format check fails if theaz ...command in the title is not inside backticks. - Then a present-tense, capitalized verb (Fix for bug fixes; Add/Change/Deprecate/Remove otherwise) and a concise summary.
- Recommended title (note the backticks around the command):
[Event Hubs] Fix #32073: `az <command>`: Fix <concise description of the fix>
Description — follow the PR template and fill in:
- Link the issue — start the Description with a closing keyword so the PR auto-links and closes it:
Fixes #32073. - Related command — the
az ...command this affects. - Description (mandatory) — why the bug happens, what you changed, and the resulting behavior.
- Testing Guide — example command(s) showing the fix works.
- History Notes — leave the title to drive the history note, or add extra lines in the same format (component in brackets + the command in backticks), e.g.
[Event Hubs] `az <command>`: <note>. - Keep the template checklist and tick the items you've satisfied.
Posted by agent-assist (autonomous bug-fix pipeline).
|
@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33636 (review) and push a fix. Posted by agent-assist (autonomous bug-fix pipeline). |
Related command
az eventhubs eventhub listDescription
az eventhubs eventhub listregressed on namespace validation and could reject service-valid short namespace names. This change adds focused regression coverage around the generated--namespace-nameschema so the accepted 6–50 character range stays aligned with the service contract.Validation coverage
Regression scope
az eventhubs eventhub listTesting Guide
az eventhubs eventhub list --resource-group <rg> --namespace-name ns0001ns0001ns001History Notes
[Event Hubs]
az eventhubs eventhub list: Add regression coverage for namespace name length validationThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.