Conversation
…ninsights in main process
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Azure CLI telemetry performance by avoiding an expensive applicationinsights import in the common path of telemetry.save(), only loading it when non-default (“extra”) instrumentation-key events are present.
Changes:
- Move
CliTelemetryClientimport behind anif extra_events:guard insave() - Split events into
cli_eventsvsextra_eventsfirst, then upload extra events only if needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+73
| for key, event in extra_events.items(): | ||
| client.add(json.dumps({key: event}), flush=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Problem
The
save()function inazure/cli/telemetry/__init__.pyunconditionally importsCliTelemetryClient, which triggers top-levelfrom applicationinsights import ...intelemetry_client.py. This loads 146 modules — even though the client is only needed for "extra events" with non-default instrumentation keys, which no extension currently uses.Fix
Defer the
CliTelemetryClientimport behind anif extra_events:guard. Events are first split by instrumentation key; only if non-default key events exist does the code import applicationinsights and create a client. The common path (all events useDEFAULT_INSTRUMENTATION_KEY) now skips the import entirely.Time Save (on DevBox)
Before:
The
savemethod takes 111ms in conclude telemetry.After:
The
savemethod takes 22ms in concluding telemetry.The
extension --helpcommand saves about 90 ms.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.