{Core} Bump MSAL to 1.35.0b1 #32611
Merged
{Core} Bump MSAL to 1.35.0b1 #32611
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Account
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the MSAL (Microsoft Authentication Library) dependency from version 1.34.0b1 to 1.35.0b1 to resolve critical issues with az login that cause the command to hang or fail when network configurations are misconfigured, particularly in managed identity authentication flows.
- Updates MSAL version across all platform-specific requirements files
- Includes both standard MSAL package and MSAL with broker support for Windows
- Picks up upstream fix that removes problematic
getfqdn()call
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/requirements.py3.windows.txt | Updates msal[broker] to 1.35.0b1 for Windows platform |
| src/azure-cli/requirements.py3.Linux.txt | Updates msal to 1.35.0b1 for Linux platform |
| src/azure-cli/requirements.py3.Darwin.txt | Updates msal to 1.35.0b1 for macOS platform |
| src/azure-cli-core/setup.py | Updates both msal and msal[broker] dependencies to 1.35.0b1 with proper platform conditionals |
Review Summary: This PR is well-structured and consistently applies the MSAL version bump across all necessary files. All platform-specific requirements files and the core setup.py have been properly updated. No issues were identified during the review.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bebound
approved these changes
Jan 7, 2026
evelyn-ys
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31900, IcM 700647529
Related command
az loginDescription
Bump MSAL to 1.35.0b1 to pick up new changes, especially the removal of
getfqdn()for managed identity flow (AzureAD/microsoft-authentication-library-for-python#859), so thataz logindoesn't hang (#31900) or fail (IcM 700647529) with misconfigured network setup.