{Compute} disk and snapshot command migration #32596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william051200
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @william051200, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the az disk create and az snapshot create commands from the legacy mgmt.compute SDK to the aaz-based implementation, modernizing the command infrastructure.
Key Changes:
- Removed SDK type references from command group definitions for disk and snapshot commands
- Simplified validator functions by removing API version checks that are no longer needed with aaz-based commands
- Cleaned up conditional validation logic that was dependent on API version support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/commands.py | Removed compute_disk_sdk and compute_snapshot_sdk parameters from command group definitions, allowing the commands to use aaz-based implementations |
| src/azure-cli/azure/cli/command_modules/vm/_validators.py | Simplified _validate_gallery_image_reference by removing the cmd parameter and API version check; removed API version validation for UploadWithSecurityData upload type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
william051200
force-pushed
the
vm-disk-snapshot-migration
branch
from
b09a45c to
cc99002
Compare
william051200
force-pushed
the
vm-disk-snapshot-migration
branch
from
cc99002 to
90d7991
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az disk createaz snapshot createDescription
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.