[DO NOT MERGE][ACR] az acr config content-trust: Begin deprecation of Docker Content Trust feature #32112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR begins the deprecation process for Docker Content Trust in Azure Container Registry as announced for retirement by March 31, 2028. The changes remove the Notary client check from health commands and add deprecation warnings to content-trust related CLI commands, while updating the enabled status handling for the update command.
- Removed Notary client health check since the feature is being deprecated
- Added deprecation notices and warnings to content-trust commands
- Updated content-trust update command to no longer accept
enabledstatus and require confirmation fordisabledstatus
Reviewed Changes
Copilot reviewed 15 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_acr_commands.py | Updated test to use --status disabled -y instead of --status enabled for content-trust update command |
| test_check_name_availability_dnl_scope.yaml | Updated test recording with newer CLI version and timestamps |
| test_check_name_availability.yaml | Updated test recording with newer CLI version and timestamps |
| test_acr_with_public_network_access_disabled.yaml | Updated test recording with newer CLI version and timestamps |
| test_acr_with_public_network_access.yaml | Updated test recording with newer CLI version and timestamps |
| test_acr_import_no_wait.yaml | Updated test recording with newer CLI version and timestamps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
microsoft-github-policy-service
bot
requested review from
northtyphoon and
terencet-dev
Contributor
|
If this PR includes any breaking chanes, we need to wait until breaking change window to release it. |
yanzhudd
modified the milestones:
October 2025 (2025-10-14),
November 2025 (2025-11-04)
3 tasks
lizMSFT
changed the title
zhoxing-ms
modified the milestones:
November 2025 (2025-11-04),
November 2025 (2025-11-18)❗ Breaking change release ❗
yanzhudd
modified the milestones:
November 2025 (2025-11-18)❗ Breaking change release ❗,
December 2025 (2025-12-02)
Contributor
|
please let us know if this PR is ready to review/merge |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
modified the milestones:
December 2025 (2025-12-02),
January 2026 (2026-01-06)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DO NOT MERGE] I'm currently working on the breaking changes announcement and will merge the PR once it's ready.
Related command
az acr check-healthaz acr config content-trustaz acr config content-trust showaz acr config content-trust updateDescription
Azure Container Registry will retire Docker Content Trust on March 31, 2028. For more details, refer to https://aka.ms/acr/dctdeprecation.
To prepare for this deprecation, the following changes have been made in this PR:
az acr check-health, as the feature is being deprecated.az acr config content-trustaz acr config content-trust showaz acr config content-trust updateaz acr config content-trust updateto no longer accept theenabledstatus value.az acr config content-trust update -r myregistry --status disabled, the CLI will:Testing Guide
History Notes
[ACR] BREAKING CHANGE:
az acr config content-trust updateno longer accepts theenabledstatus.[ACR] BREAKING CHANGE:
az acr check-health: Removed Notary client check due to Docker Content Trust deprecation.[ACR]
az acr config content-trust,show,update: Added deprecation labels and notices.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.