Skip to content

[AKS] Add --enable-hosted-system, --system-node-subnet-id and --node-subnet-id to az aks update - #10199

Open
reneeli123 wants to merge 2 commits into
Azure:mainfrom
reneeli123:reneel/support-non-hobo-hobo
Open

[AKS] Add --enable-hosted-system, --system-node-subnet-id and --node-subnet-id to az aks update#10199
reneeli123 wants to merge 2 commits into
Azure:mainfrom
reneeli123:reneel/support-non-hobo-hobo

Conversation

@reneeli123

@reneeli123 reneeli123 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes
⚠️ None
⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_hosted_system
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter node_subnet_id
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter system_node_subnet_id

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update -n $auto-cluster -g $auto-rg --enable-hosted-system --apiserver-subnet-id(optional for byo) --node-subnet-id(optional for byo) --system-node-subnet-id(optional for byo)

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI lite review requested due to automatic review settings August 11, 2026 04:20
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi reneeli123,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the aks-preview extension’s az aks update flow to support converting an existing Automatic SKU cluster to use a Managed System Pool (hosted system), optionally alongside BYO VNet subnet configuration.

Changes:

  • Adds --enable-hosted-system, --system-node-subnet-id, and --node-subnet-id to az aks update (params, custom entrypoint wiring, and help).
  • Implements update-time handling for hosted_system_profile via update_hosted_system_profile, including validation and SKU-specific error messaging.
  • Adds unit test coverage for hosted-system update behavior and documents the change in HISTORY.rst.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/aks-preview/HISTORY.rst Documents the new az aks update parameters and scenario in the next release entry.
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py Adds unit tests for hosted-system update behavior (enablement, BYO trio, and validation failures).
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Adds hosted-system update implementation + refines validation/error messaging for update mode; wires into update flow.
src/aks-preview/azext_aks_preview/custom.py Wires new parameters into the aks_update command signature so they reach the decorator.
src/aks-preview/azext_aks_preview/_params.py Exposes the new CLI arguments (including validators) under aks update.
src/aks-preview/azext_aks_preview/_help.py Adds help text and examples for the new update flags and BYO subnet trio behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
@reneeli123
reneeli123 force-pushed the reneel/support-non-hobo-hobo branch from a7f9157 to 07d1612 Compare August 11, 2026 04:27
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants