Add examples for getting secrets for VMs #56
Conversation
…com/BernieWhite/PSRule.Rules.Azure-quickstart into bewhite/add-keyvault-secret-example
|
Please review @Tatsinnit. Thanks. |
Tatsinnit
left a comment
Tatsinnit
left a comment
There was a problem hiding this comment.
💡 Thank you so much for the kind ping! I've added a few thoughts—though I'm not entirely sure about their full relevance, I do feel it might be helpful to note whether these files are generated by a tool or adapted from somewhere else.
Also, regarding the constants and GUIDs in use—it would be great to document the purpose behind them, especially since they may potentially be referenced by end users. Highlighting any possible downsides or considerations could be valuable too. 🙏
| // --------- | ||
|
|
||
| var roles = { | ||
| Owner: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '8e3af657-a8ff-443c-a75c-2fe8c4bcb635') |
There was a problem hiding this comment.
💡 Thoughts: Can we add any documentation which contains these relationships and GUID relevance please.
| @@ -0,0 +1,204 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
There was a problem hiding this comment.
💡 These looks like auto generated or from a source, have we added those source for archival reasons.
2 participants
PR Summary
Add new examples for working with secrets in the pipeline and key vault.
PR Checklist