Skip to content

Regenerate clients from current connector swagger#210

Open
daviburg wants to merge 16 commits into
mainfrom
chore/regenerate-clients-from-bpm
Open

Regenerate clients from current connector swagger#210
daviburg wants to merge 16 commits into
mainfrom
chore/regenerate-clients-from-bpm

Conversation

@daviburg

@daviburg daviburg commented Jul 14, 2026

Copy link
Copy Markdown
Member

Description

Regenerates all 97 existing .NET Connector SDK clients from current managed-connector Swagger using AzureUX-BPM PR 16421737. The companion generator PR replaces ARMClient with Azure Identity DefaultAzureCredential, preserves valid ARM JSON before malformed-response fallbacks, filters deprecated operations in C#, TypeScript, and Python, handles mixed JSON/multipart declarations correctly, and sends binary Swagger bodies as raw bytes.

Dependency: AzureUX-BPM PR 16421737 must merge before this generated-output PR.

Changes

  • Regenerated all 97 existing clients, including Office 365, Docuware, and SigningHub, from fresh ARM exports.
  • Removed deprecated or unsupported operations and added current Swagger operations.
  • Added Unreleased changelog entries for breaking API removals, named-argument changes, new operations, and corrected owner contracts.
  • Updated generation guidance for Azure CLI-backed DefaultAzureCredential authentication.
  • Removed compatibility overrides that contradicted AAPT connector-owner Swagger or runtime policy.
  • Modeled Azure Queues' actual nested QueueMessagesList.QueueMessage[] response with named generated types.
  • Preserved Azure Queues DequeueCount as a runtime-contract correction: Azure Storage returns it and connector policy passes it through, although complete AAPT Swagger history omits it.
  • Kept DocumentDB dynamic fields on each ObjectWithoutType document item instead of inventing an envelope property.
  • Honored Event Hubs required parameters and Microsoft Forms/Word Online Business internal discovery contracts.
  • Added raw binary request transport and regenerated 32 binary operations across 18 clients to send unchanged application/octet-stream bodies instead of JSON/base64.
  • Replaced 32 generated application/octet-stream literals across 18 clients with System.Net.Mime.MediaTypeNames.Application.Octet; connector-declared custom binary media types remain literals.
  • Added URI regressions for paths marked x-ms-url-encoding: "double".
  • Tracked full Swagger 2.0 multipart/form-data transport and generation support in Add Swagger 2.0 multipart/form-data operation support #212; multipart-only/formData operations remain excluded until that work is complete.

Validation

  • SDK tests: 898 passed, 0 failed, 0 skipped.
  • BPM generator check-in tests: 461 passed, 0 failed, 2 skipped.
  • Markdown lint: npx markdownlint-cli2@0.17.2 '**/*.md' reports 0 errors.
  • Fresh generation succeeds independently for office365, docuware, and signinghub.
  • Live read-only account-name validation passes for Azure Queues (ListQueues, HTTP 200) and Azure Blob (ListRootFolder, HTTP 200).
  • Full storage-endpoint mode remains unverified because existing discovery returns account names. An endpoint-capable E2E fixture is required.

Checklist

  • Code follows repository conventions.
  • Files under src/**/Generated/ were produced by the BPM CodefulSdkGenerator.
  • Documentation updated.
  • CHANGELOG.md updated under Unreleased, including breaking changes.
  • release_notes.md updated (not shipping a new version in this PR).
  • Version updated in eng/build/Version.props (not shipping a new version in this PR).

Regenerates existing clients with AzureUX-BPM PR 16421737 and aligns affected contract tests.

Co-authored-by: Dobby <dobby@microsoft.com>
@daviburg daviburg requested a review from a team as a code owner July 14, 2026 01:25
Copilot AI review requested due to automatic review settings July 14, 2026 01:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the Connectors .NET SDK’s generated clients from the current managed-connector Swagger, aligned with the companion generator changes (AzureUX-BPM PR 16421737) that remove deprecated operations and switch generation-time auth guidance to Azure Identity / DefaultAzureCredential.

Changes:

  • Regenerated connector client code under src/Azure.Connectors.Sdk/Generated/ to reflect current Swagger surface (including additions/removals of operations and contract shape updates).
  • Updated/trimmed unit tests to align with regenerated clients (e.g., DocuSign parameter renames; removed Cloudmersive autodetect coverage for an operation no longer present).
  • Updated GENERATION.md to document Azure CLI login and DefaultAzureCredential-based generation, including notes about retained baseline artifacts.

Reviewed changes

Copilot reviewed 3 out of 37 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tests/Azure.Connectors.Sdk.Tests/DocuSignClientTests.cs Updates test calls to match regenerated DocuSign parameter names.
tests/Azure.Connectors.Sdk.Tests/CloudmersiveConvertClientTests.cs Removes tests for an operation no longer present in current Swagger.
src/Azure.Connectors.Sdk/Generated/ZohoSignExtensions.cs Removes deprecated model/method surface from regenerated Zoho Sign client.
src/Azure.Connectors.Sdk/Generated/ZendeskExtensions.cs Regenerated Zendesk client paths and operations.
src/Azure.Connectors.Sdk/Generated/WordOnlineBusinessExtensions.cs Regenerated Word Online (Business) client signatures/behavior.
src/Azure.Connectors.Sdk/Generated/TeamsExtensions.cs Adds/removes Teams operations and related models per current Swagger.
src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs Regenerated SQL connector paths and operations.
src/Azure.Connectors.Sdk/Generated/ServicebusExtensions.cs Regenerated Service Bus connector paths and operations.
src/Azure.Connectors.Sdk/Generated/SalesforceExtensions.cs Regenerated Salesforce connector models/docs and paths.
src/Azure.Connectors.Sdk/Generated/PlannerExtensions.cs Regenerated Planner models/docs.
src/Azure.Connectors.Sdk/Generated/PdfCoExtensions.cs Regenerated PDF.co models/docs.
src/Azure.Connectors.Sdk/Generated/OutlookExtensions.cs Regenerated Outlook connector paths and operations.
src/Azure.Connectors.Sdk/Generated/OneDriveForBusinessExtensions.cs Regenerated OneDrive for Business connector paths and operations.
src/Azure.Connectors.Sdk/Generated/OneDriveExtensions.cs Regenerated OneDrive connector paths and operations.
src/Azure.Connectors.Sdk/Generated/Office365UsersExtensions.cs Regenerated Office 365 Users models/docs.
src/Azure.Connectors.Sdk/Generated/Office365GroupsExtensions.cs Regenerated Office 365 Groups paths and operations.
src/Azure.Connectors.Sdk/Generated/MicrosoftFormsExtensions.cs Regenerated Microsoft Forms operations and return types.
src/Azure.Connectors.Sdk/Generated/MailChimpExtensions.cs Regenerated MailChimp models/docs.
src/Azure.Connectors.Sdk/Generated/JedoxOdataHubExtensions.cs Regenerated Jedox OData Hub paths/encoding.
src/Azure.Connectors.Sdk/Generated/GoogleDriveExtensions.cs Regenerated Google Drive connector paths and operations.
src/Azure.Connectors.Sdk/Generated/FtpExtensions.cs Regenerated FTP connector paths and operations.
src/Azure.Connectors.Sdk/Generated/ExcelOnlineExtensions.cs Regenerated Excel Online connector paths and operations.
src/Azure.Connectors.Sdk/Generated/ExcelOnlineBusinessExtensions.cs Regenerated Excel Online (Business) connector paths and operations.
src/Azure.Connectors.Sdk/Generated/EventhubsExtensions.cs Regenerated Event Hubs operation signatures and request construction.
src/Azure.Connectors.Sdk/Generated/EtsyExtensions.cs Regenerated Etsy models/docs and operations.
src/Azure.Connectors.Sdk/Generated/ElfsquadDataExtensions.cs Regenerated Elfsquad Data docs and operations.
src/Azure.Connectors.Sdk/Generated/DynamicsAXExtensions.cs Regenerated Dynamics AX connector paths and operations.
src/Azure.Connectors.Sdk/Generated/DropboxExtensions.cs Regenerated Dropbox connector paths and operations.
src/Azure.Connectors.Sdk/Generated/DocumentdbExtensions.cs Regenerated DocumentDB (Cosmos DB) models and factories.
src/Azure.Connectors.Sdk/Generated/BoxExtensions.cs Regenerated Box connector paths and operations.
src/Azure.Connectors.Sdk/Generated/AzuretablesExtensions.cs Regenerated Azure Tables connector paths and operations.
src/Azure.Connectors.Sdk/Generated/AzurequeuesExtensions.cs Regenerated Azure Queues models and paths.
src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs Regenerated Azure Blob connector paths and operations.
GENERATION.md Updates generation prerequisites/auth flow and documents the 2026-07 regeneration notes.

Comment thread src/Azure.Connectors.Sdk/Generated/PdfCoExtensions.cs Outdated
Comment thread src/Azure.Connectors.Sdk/Generated/ElfsquadDataExtensions.cs Outdated
Comment thread src/Azure.Connectors.Sdk/Generated/MailChimpExtensions.cs Outdated
Comment thread src/Azure.Connectors.Sdk/Generated/ZendeskExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/ServicebusExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/AzurequeuesExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/Office365GroupsExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/PlannerExtensions.cs Outdated
Comment thread src/Azure.Connectors.Sdk/Generated/PlannerExtensions.cs Outdated
Regenerates Office365, Docuware, and SigningHub after BPM generator fixes, records breaking changes under Unreleased, and applies generator-owned Swagger text corrections.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 38 changed files in this pull request and generated 7 comments.

Comment thread src/Azure.Connectors.Sdk/Generated/ZendeskExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/AzurequeuesExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/WordOnlineBusinessExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/EventhubsExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/EventhubsExtensions.cs
Comment thread CHANGELOG.md Outdated
Comment thread src/Azure.Connectors.Sdk/Generated/MailChimpExtensions.cs
Makes existing contract patches formatting-independent, expands breaking-change notes, and adds a Zendesk double-encoding URI regression.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 36 changed files in this pull request and generated 3 comments.

Comment thread tests/Azure.Connectors.Sdk.Tests/ZendeskClientTests.cs Outdated
Comment thread tests/Azure.Connectors.Sdk.Tests/CloudmersiveConvertClientTests.cs
Comment thread src/Azure.Connectors.Sdk/Generated/EtsyExtensions.cs Outdated
Regenerates Etsy with the corrected wire property name, restores Cloudmersive operation success and error coverage, and uses a portable Zendesk URI assertion.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 16:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 36 changed files in this pull request and generated 2 comments.

Comment thread src/Azure.Connectors.Sdk/Generated/AzurequeuesExtensions.cs
Comment thread CHANGELOG.md
Captures the outgoing ListQueues request and verifies endpoint-shaped storage account values remain double encoded as required by connector Swagger.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 37 changed files in this pull request and generated 2 comments.

Comment thread src/Azure.Connectors.Sdk/Generated/AzurequeuesExtensions.cs
Comment thread CHANGELOG.md
Regenerates QueueMessage with TimeNextVisible and DequeueCount and adds wire-deserialization coverage.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 17:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 37 changed files in this pull request and generated 1 comment.

Comment thread CHANGELOG.md
Copilot AI review requested due to automatic review settings July 14, 2026 17:18
@daviburg daviburg self-assigned this Jul 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 37 changed files in this pull request and generated 1 comment.

Comment thread CHANGELOG.md
Updates scheduled generation, troubleshooting, and connector discovery examples to use Azure CLI and DefaultAzureCredential-compatible authentication.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 17:54
Renames unused cancellation-token lambda parameters in Azure Queues and Zendesk request capture helpers.

Co-authored-by: Dobby <dobby@microsoft.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 37 changed files in this pull request and generated 3 comments.

Comment thread src/Azure.Connectors.Sdk/Generated/SigningHubExtensions.cs
Comment thread src/Azure.Connectors.Sdk/Generated/SigningHubExtensions.cs
Comment thread CHANGELOG.md
Copilot AI review requested due to automatic review settings July 14, 2026 18:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 37 changed files in this pull request and generated no new comments.

Adds raw binary transport overloads, regenerates 32 string/binary operations across 18 clients with application/octet-stream content, and adds shared plus SigningHub wire-level coverage.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 18:46
Comment thread tests/Azure.Connectors.Sdk.Tests/ConnectorClientBaseTests.cs
Comment thread tests/Azure.Connectors.Sdk.Tests/SigningHubClientTests.cs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 45 changed files in this pull request and generated no new comments.

Regenerates Queue, DocumentDB, Event Hubs, Forms, and Word clients from canonical owner contracts, adds wire-shape regressions, and documents the breaking changes.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 49 changed files in this pull request and generated 1 comment.

Comment thread src/Azure.Connectors.Sdk/ConnectorClientBase.cs
Replaces 32 generated octet-stream literals with MediaTypeNames.Application.Octet and clarifies binary response documentation.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 23:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 49 changed files in this pull request and generated 1 comment.

Comment thread src/Azure.Connectors.Sdk/ConnectorClientBase.cs Outdated
Regenerates the runtime response field and verifies nested message responses retain its value.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 14, 2026 23:21
Describes both raw byte and deserialized JSON results on the binary request overload.

Co-authored-by: Dobby <dobby@microsoft.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 49 changed files in this pull request and generated 1 comment.

public class VariateSettings
{
/// <summary>The combination that performs the best. This may be determined automatically by click rate, open rate, or total revenue-or you may choose manually based on the reporting data you find the most valuable. For Multivariate Campaigns testing send_time, winner_critera is ignored. For Multivariate Campaigns with &apos;manual&apos; as the winner_citeria, the winner must be chosen in the MailChimp web application</summary>
/// <summary>The combination that performs the best. This may be determined automatically by click rate, open rate, or total revenueor you may choose manually based on the reporting data you find the most valuable. For Multivariate Campaigns testing send_time, winner_critera is ignored. For Multivariate Campaigns with &apos;manual&apos; as the winner_citeria, the winner must be chosen in the MailChimp web application</summary>
Copilot AI review requested due to automatic review settings July 14, 2026 23:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 49 changed files in this pull request and generated 1 comment.

Comment on lines +90 to +94
public static (TokenCredential Credential, ConnectorClientOptions Options, Func<byte[]?> GetBody, Func<string?> GetContentType) CreateContentCapturingClientSetup(
Func<HttpResponseMessage> responseFactory)
{
var mockCredential = new Mock<TokenCredential>();
mockCredential
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants