fix: copy VHD to and from blob#8610
Open
timmy-wright wants to merge 4 commits into
Open
Conversation
timmy-wright
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd and
zachary-bailey
as code owners
timmy-wright
force-pushed
the
timmy/test-embargo-process-2
branch
from
058ef49 to
c1daab4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an optional Windows VHD pipeline step that detects builds sourced from a 1P shared gallery and recreates the produced SIG image version from a temporary managed disk to break gallery lineage before downstream validation/publishing.
Changes:
- Reads
sig_source_gallery_namefrom Windows settings to decide whether lineage breaking is needed. - Creates a temporary managed disk from the built SIG image version.
- Deletes and recreates the SIG image version from that disk, then updates
MANAGED_SIG_ID.
timmy-wright
force-pushed
the
timmy/test-embargo-process-2
branch
from
c1daab4 to
3ac47b6
Compare
timmy-wright
added
windows
ignore-for-release
| --gallery-name "${SIG_GALLERY_NAME}" \ | ||
| --gallery-image-definition "${SIG_IMAGE_NAME}" \ | ||
| --gallery-image-version "${SIG_IMAGE_VERSION}" \ | ||
| --os-snapshot "${DISK_ID}" \ |
Comment on lines
+153
to
+158
| az sig image-version wait \ | ||
| --resource-group "${AZURE_RESOURCE_GROUP_NAME}" \ | ||
| --gallery-name "${SIG_GALLERY_NAME}" \ | ||
| --gallery-image-definition "${SIG_IMAGE_NAME}" \ | ||
| --gallery-image-version "${SIG_IMAGE_VERSION}" \ | ||
| --deleted 2>/dev/null || sleep 30 |
timmy-wright
changed the title
Azure requires AutomaticOSUpgradePolicy.EnableAutomaticOSUpgrade=true when creating a VMSS from an official 1P gallery image. Without this, VMSS creation fails with: "Virtual Machine Scale Set using official 1P gallery cannot be created without enabling AutomaticOSUpgrade." Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| --replica-count 1 | ||
| -o none | ||
| ) | ||
| if [ "${ORIGINAL_TAGS}" != "{}" ] && [ -n "${ORIGINAL_TAGS}" ]; then |
| --gallery-name "${SIG_GALLERY_NAME}" | ||
| --gallery-image-definition "${SIG_IMAGE_NAME}" | ||
| --gallery-image-version "${SIG_IMAGE_VERSION}" | ||
| --os-snapshot "${DISK_ID}" |
Comment on lines
+247
to
+249
| vmss.Properties.UpgradePolicy.AutomaticOSUpgradePolicy = &armcompute.AutomaticOSUpgradePolicy{ | ||
| EnableAutomaticOSUpgrade: to.Ptr(true), | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #