Skip to content

feat: windows base version update & script to do it manually#8315

Merged
timmy-wright merged 4 commits intomainfrom
timmy/windows-base-version-updates
Apr 15, 2026
Merged

feat: windows base version update & script to do it manually#8315
timmy-wright merged 4 commits intomainfrom
timmy/windows-base-version-updates

Conversation

@timmy-wright
Copy link
Copy Markdown
Contributor

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Copilot AI review requested due to automatic review settings April 15, 2026 00:30
@timmy-wright timmy-wright changed the title feat: aks-node-controller self-update mechanism and version command support (#8257) feat: windows base version update & script to do it manually Apr 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Windows VHD base image versions and adds a helper script/Makefile target to refresh those versions via Azure CLI queries.

Changes:

  • Bumped multiple base_image_version values in windows_settings.json.
  • Added update_windows_base_versions.sh to query the latest Azure Marketplace image versions and optionally update the settings file.
  • Added a make update-windows-base-versions target to run the script.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
vhdbuilder/packer/windows/windows_settings.json Updates pinned Windows base image versions used by the VHD builder.
vhdbuilder/packer/windows/update_windows_base_versions.sh Adds a manual script to query Azure Marketplace and update base_image_version entries.
Makefile Adds a convenience target to run the new update script.
Comments suppressed due to low confidence (1)

vhdbuilder/packer/windows/update_windows_base_versions.sh:1

  • Suppressing az stderr (2>/dev/null) combined with || true obscures actionable failures (e.g., not logged in, missing subscription/permissions, CLI argument errors). Consider preserving and surfacing errors (e.g., capture stderr and print it when latest_version is empty) so operators can distinguish 'no versions found' from 'query failed'.
#!/bin/bash

Copilot AI review requested due to automatic review settings April 15, 2026 03:47
@timmy-wright timmy-wright force-pushed the timmy/windows-base-version-updates branch from c82a65a to 99c0e90 Compare April 15, 2026 03:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

@github-actions
Copy link
Copy Markdown
Contributor

Changes cached containers or packages on windows VHDs

Please get a Windows SIG member to approve.

The following dif file shows any additions or deletions from what will be cached on windows VHDs organised by VHD type.

  • Additions are new things cached.
  • Deletions are things no longer cached.
diff --git a/vhd_files/2022-containerd-gen2.txt b/vhd_files/2022-containerd-gen2.txt
index 4573534..27d2313 100644
--- a/vhd_files/2022-containerd-gen2.txt
+++ b/vhd_files/2022-containerd-gen2.txt
@@ -147 +147 @@ Windows 2022-containerd-gen2 base image sku: 2022-datacenter-core-smalldisk-g2
-Windows 2022-containerd-gen2 base version: 20348.4893.260303
+Windows 2022-containerd-gen2 base version: 20348.5020.260413
diff --git a/vhd_files/2022-containerd.txt b/vhd_files/2022-containerd.txt
index e93d818..9988c5f 100644
--- a/vhd_files/2022-containerd.txt
+++ b/vhd_files/2022-containerd.txt
@@ -147 +147 @@ Windows 2022-containerd base image sku: 2022-Datacenter-Core-smalldisk
-Windows 2022-containerd base version: 20348.4893.260303
+Windows 2022-containerd base version: 20348.5020.260413
diff --git a/vhd_files/2025-gen2.txt b/vhd_files/2025-gen2.txt
index e4770d4..efe2d52 100644
--- a/vhd_files/2025-gen2.txt
+++ b/vhd_files/2025-gen2.txt
@@ -80 +80 @@ Windows 2025-gen2 base image sku: 2025-datacenter-core-smalldisk-g2
-Windows 2025-gen2 base version: 26100.32522.260306
+Windows 2025-gen2 base version: 26100.32690.260413
diff --git a/vhd_files/2025.txt b/vhd_files/2025.txt
index 264826e..3f82530 100644
--- a/vhd_files/2025.txt
+++ b/vhd_files/2025.txt
@@ -80 +80 @@ Windows 2025 base image sku: 2025-datacenter-core-smalldisk
-Windows 2025 base version: 26100.32522.260306
+Windows 2025 base version: 26100.32690.260413
diff --git a/vhd_files/23H2-gen2.txt b/vhd_files/23H2-gen2.txt
index 9611e11..eaf98bb 100644
--- a/vhd_files/23H2-gen2.txt
+++ b/vhd_files/23H2-gen2.txt
@@ -95 +95 @@ Windows 23H2-gen2 base image sku: 23h2-datacenter-core-g2
-Windows 23H2-gen2 base version: 25398.2207.260303
+Windows 23H2-gen2 base version: 25398.2274.260411
diff --git a/vhd_files/23H2.txt b/vhd_files/23H2.txt
index 5219b4d..d194cfa 100644
--- a/vhd_files/23H2.txt
+++ b/vhd_files/23H2.txt
@@ -95 +95 @@ Windows 23H2 base image sku: 23h2-datacenter-core
-Windows 23H2 base version: 25398.2207.260303
+Windows 23H2 base version: 25398.2274.260411

@timmy-wright timmy-wright merged commit 37deed5 into main Apr 15, 2026
32 of 36 checks passed
@timmy-wright timmy-wright deleted the timmy/windows-base-version-updates branch April 15, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants