Fix Windows pgvector CI build by dynamically locating Visual Studio install path - #302
Open
Pamela Fox (pamelafox) with Copilot wants to merge 3 commits into
Open
Fix Windows pgvector CI build by dynamically locating Visual Studio install path#302Pamela Fox (pamelafox) with Copilot wants to merge 3 commits into
Pamela Fox (pamelafox) with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: pamelafox <297042+pamelafox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI broken for pgvector on Windows
Fix Windows pgvector CI build by dynamically locating Visual Studio install path
Aug 5, 2026
Pamela Fox (pamelafox)
marked this pull request as ready for review
August 6, 2026 11:38
Pamela Fox (pamelafox)
approved these changes
Aug 6, 2026
Pamela Fox (pamelafox)
approved these changes
Aug 6, 2026
Gwyneth Peña-Siguenza (madebygps)
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI jobs failed to build pgvector because the workflow hardcoded the Visual Studio install path (
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\...), andvcvars64.batcould not be found once thewindows-latestrunner image no longer matched that assumed path/edition.Changes
.github/workflows/app-tests.yaml: replaced the hardcodedvcvars64.batpath with avswhere.exelookup that resolves the actual installed Visual Studio location before calling it..github/workflows/install-pgvector.bat: applied the samevswhere.exe-based lookup for consistency.This makes the pgvector build step resilient to changes in the Visual Studio edition or version pre-installed on GitHub-hosted Windows runners.