chore: update bicep iac config #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Bicep IaC configuration for the project, focusing on renaming services from “llama-index-nextjs” to “llama-index-javascript” and removing several shared module files.
- Added a detailed next-steps documentation file outlining the process after running azd commands.
- Removed obsolete/shared Bicep modules such as role, registry, monitoring, keyvault, cognitiveservices, apps-env, and the legacy llama-index-nextjs app.
- Updated main Bicep and parameters files to reflect the new configuration and naming conventions.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| next-steps.md | Added documentation on post-init steps after azd init |
| infra/shared/*.bicep | Removed several shared modules no longer required |
| infra/resources.bicep | Introduced updated resource deployments using the new naming |
| infra/main.parameters.json | Updated parameters to use "llama-index-javascript" naming |
| infra/main.bicep | Refactored configuration to remove legacy modules and adjust outputs |
| infra/abbreviations.json | Added a new abbreviation entry |
| azure.yaml | Updated service name and template version for the JavaScript service |
Comments suppressed due to low confidence (3)
infra/resources.bicep:63
- [nitpick] Consider renaming the resource name to 'llamaIndexJavascriptIdentity' (with a capital 'I') for consistency in camel case usage.
name: 'llamaIndexJavascriptidentity'
azure.yaml:5
- [nitpick] Verify that the updated service name and template version correctly reflect the intended deployment configuration across your IaC.
template: llama-index-javascript@1.15.1
infra/shared/role.bicep:1
- Ensure the removal of this role module is intentional and that any dependencies on it have been updated in the deployment pipeline.
-metadata description = 'Creates a role assignment for a service principal.'
| tags: tags | ||
| name: '${abbrs.keyVaultVaults}${resourceToken}' | ||
| principalId: principalId | ||
| llamaIndexJavascriptExists: llamaIndexJavascriptExists |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining the purpose of the 'llamaIndexJavascriptExists' parameter for improved maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.