Included mountstats and nfsstats in logs #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ksub42
commented
May 13, 2023
ksub42
commented
- Included mountstats & nfsstats in the logs that we collect.
- Cleaned up code and fixed two misc bugs (one in arg parsing, one in killing tcpdump).
- Fixed Python invocation to be independend of the actual location of the Python interpreter in trace-nfsbpf.
1. Included mountstats & nfsstats in the logs that we collect.
2. Cleaned up code and fixed two misc bugs (one in arg parsing,
one in killing tcpdump).
3. Fixed Python invocation to be independend of the actual location of
the Python interpreter in trace-nfsbpf.
NfsDiagnostics/nfsclientlogs.sh
Outdated
| # trace-nfsbpf | ||
| ABSOLUTE_PATH="$(cd "$(dirname "trace-nfsbpf")" && pwd)/$(basename "trace-nfsbpf")" | ||
| progfile2="nohup $ABSOLUTE_PATH" | ||
| NFSBPF_ABSOLUTE_PATH="$(cd "$(dirname "trace-nfsbpf")" && pwd)/$(basename "trace-nfsbpf")" |
Collaborator
There was a problem hiding this comment.
why not simply do:
$ realpath trace-nfsbpf
sprasad-microsoft
approved these changes
May 16, 2023
Collaborator
sprasad-microsoft
left a comment
sprasad-microsoft
left a comment
There was a problem hiding this comment.
Overall changes look good. Just had a minor comment.
Please do some testing and merge the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.