chore: remove deploy script, deployments.json, and their five dependencies - #33
Open
alejoamiras wants to merge 1 commit into
Open
chore: remove deploy script, deployments.json, and their five dependencies#33alejoamiras wants to merge 1 commit into
alejoamiras wants to merge 1 commit into
Conversation
…ncies The Foundation does not intend to publish canonical devnet example deployments. deployments.json (inherited from the defi-wonderland fork, PR defi-wonderland#95 there) recorded pre-5.0 addresses, was unshipped since d7637ef, and has no reader in-repo or public consumer on GitHub. The deploy script (their PR defi-wonderland#296, explicitly 'not meant for a productive environment') had been broken since 4.2.0 with nobody noticing, is never invoked by CI, and is unrelated to benchmarks, which deploy their own instances via setupTestSuite. With the deploy chain gone, its exclusive dependencies leave with it: commander, dotenv, tsx, @aztec/accounts, @aztec/noir-contracts.js. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: multitoken
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #28 (merge that first; if it squash-merges, this branch gets rebased before retargeting
main).What & why
The Foundation doesn't intend to publish canonical devnet example deployments, so the whole deploy chain goes:
src/deployments.json— inherited from the defi-wonderland fork (their feat: residency defi-wonderland/aztec-standards#95). Recorded pre-5.0 addresses, unshipped sinced7637ef, no in-repo reader, zero public consumers on GitHub code search.scripts/deploy.ts(+deploy-config.ts,constants.ts, thedeployscript) — per its original PR, "not meant for a productive environment"; broken since 4.2.0 with nobody noticing; never invoked by CI; unrelated to benchmarks (those deploy their own instances viasetupTestSuite).Why five dependencies fall out
Each of these had
scripts/deploy.tsas its only consumer (verified by exhaustive import audit — all import forms, subpaths, workflows):commander(its CLI),dotenv(its.envload),tsx(its runner via thedeployscript),@aztec/accounts(deriveSecretKeyFromSigningKey),@aztec/noir-contracts.js(SponsoredFPC registration). With the script deleted they're removable with zero replacement code.@aztec/accounts/dotenv/commanderremain in the lockfile as transitives of the Aztec SDK;aztec-benchmarkships its own pinnedtsxinternally.Also trimmed: deploy-only vars from
.env.example(NODE_URLstays — tests use it), a stale packaging comment inbuild-package.sh, and a stale deploy reference in the bump-aztec-version skill doc.Validation
yarn install --frozen-lockfile,yarn format:check, and a repo-wide dangling-reference sweep all pass; CI/release workflows and READMEs never referenced the deploy chain. Codex-reviewed (1 round): approved; its one finding (stale skill-doc line) is fixed in this diff.🤖 Generated with Claude Code