Skip to content

style: format vault regression test - #23

Merged
IlyasRidhuan merged 1 commit into
mainfrom
fix/vault-test-fmt
Aug 19, 2026
Merged

style: format vault regression test#23
IlyasRidhuan merged 1 commit into
mainfrom
fix/vault-test-fmt

Conversation

@alejoamiras

Copy link
Copy Markdown
Collaborator

Main currently fails aztec-nargo fmt --check: the pre-commit hook formats .nr files without re-staging, so #22 merged the pre-format version of the new regression test. Formatting only — no code change. cc @IlyasRidhuan

🤖 Generated with Claude Code

Prevents recurrence of committing pre-format versions (root cause of
the fmt drift fixed in the previous commit).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Benchmark Comparison

CPU Cores RAM Arch
AMD EPYC 9V74 80-Core Processor 4 16 GiB x64

Contract: escrow

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
(partial) withdraw 485,780 485,780 3,744 3,744 587,800 587,800 13,838 11,718 -2,120 (-15.3%)
withdraw 330,054 330,054 832 832 499,700 499,700 11,178 9,500 -1,678 (-15.0%)
withdraw_nft 378,231 378,231 1,440 1,440 527,400 527,400 12,313 10,427 -1,886 (-15.3%)

Contract: logic

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
get_escrow 390,336 390,336 192 192 456,000 456,000 12,439 10,681 -1,758 (-14.1%)
secret_key_to_public_keys 387,695 387,695 192 192 456,000 456,000 12,459 10,578 -1,881 (-15.1%)
share_escrow 304,211 304,211 1,952 1,952 520,700 520,700 10,952 9,353 -1,599 (-14.6%)

Contract: multitoken

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 260,232 260,232 832 832 499,700 499,700 10,162 8,659 -1,503 (-14.8%)
burn_public 223,800 223,800 416 416 638,292 638,292 9,758 8,308 -1,450 (-14.9%)
initialize_transfer_commitment 225,054 225,054 768 768 474,500 474,500 9,690 8,238 -1,452 (-15.0%)
mint_to_private 297,795 297,795 1,408 1,408 511,400 511,400 10,932 9,368 -1,564 (-14.3%)
mint_to_public 223,800 223,800 416 416 637,800 637,800 9,657 8,275 -1,382 (-14.3%)
transfer_private_to_commitment 263,571 263,571 1,024 1,024 511,400 511,400 10,233 8,722 -1,511 (-14.8%)
transfer_private_to_private 336,124 336,124 2,048 2,048 555,100 555,100 11,350 9,732 -1,618 (-14.3%)
transfer_private_to_public 306,785 306,785 1,056 1,056 714,677 714,677 10,953 9,374 -1,579 (-14.4%)
transfer_public_to_commitment 223,800 223,800 640 640 663,516 663,516 9,772 8,287 -1,485 (-15.2%)
transfer_public_to_private 298,556 298,556 1,024 1,024 683,958 683,958 10,807 9,328 -1,479 (-13.7%)
transfer_public_to_public 223,800 223,800 480 480 673,505 673,505 9,690 8,302 -1,388 (-14.3%)

Contract: nft

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 275,232 275,232 416 416 661,052 661,052 10,545 8,960 -1,585 (-15.0%)
burn_public 223,800 223,800 448 448 670,034 670,034 9,681 8,341 -1,340 (-13.8%)
mint_to_private 341,272 341,272 1,600 1,600 735,342 735,342 11,468 9,797 -1,671 (-14.6%)
mint_to_public 223,800 223,800 448 448 670,718 670,718 9,684 8,262 -1,422 (-14.7%)
transfer_private_to_private 249,433 249,433 832 832 499,700 499,700 9,934 8,526 -1,408 (-14.2%)
transfer_private_to_public 275,261 275,261 416 416 659,258 659,258 10,665 9,026 -1,639 (-15.4%)
transfer_public_to_private 292,557 292,557 992 992 683,268 683,268 10,774 9,189 -1,585 (-14.7%)
transfer_public_to_public 223,800 223,800 384 384 633,285 633,285 9,661 8,286 -1,375 (-14.2%)

Contract: token

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
burn_private 303,054 303,054 1,024 1,024 713,957 713,957 10,915 9,246 -1,669 (-15.3%)
burn_public 223,800 223,800 448 448 672,632 672,632 9,641 8,221 -1,420 (-14.7%)
initialize_transfer_commitment 225,054 225,054 768 768 474,500 474,500 9,656 8,142 -1,514 (-15.7%)
mint_to_private 355,507 355,507 2,144 2,144 738,070 738,070 11,648 10,041 -1,607 (-13.8%)
mint_to_public 223,800 223,800 448 448 672,227 672,227 9,639 8,251 -1,388 (-14.4%)
transfer_private_to_commitment 259,896 259,896 992 992 511,400 511,400 10,090 8,526 -1,564 (-15.5%)
transfer_private_to_private 343,699 343,699 2,592 2,592 557,600 557,600 11,476 9,732 -1,744 (-15.2%)
transfer_private_to_public 303,110 303,110 1,024 1,024 714,023 714,023 10,803 9,266 -1,537 (-14.2%)
transfer_private_to_public_with_commitment 307,280 307,280 1,600 1,600 747,323 747,323 10,961 9,272 -1,689 (-15.4%)
transfer_public_to_commitment 223,800 223,800 576 576 662,529 662,529 9,696 8,205 -1,491 (-15.4%)
transfer_public_to_private 296,520 296,520 992 992 683,304 683,304 10,819 9,185 -1,634 (-15.1%)
transfer_public_to_public 223,800 223,800 448 448 672,548 672,548 9,621 8,229 -1,392 (-14.5%)

Contract: vault

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
deposit_private_to_private 507,983 507,983 1,312 1,312 878,248 878,248 14,177 12,063 -2,114 (-14.9%)
deposit_private_to_private_exact 611,708 611,708 1,888 1,888 915,316 915,316 16,094 13,753 -2,341 (-14.5%)
deposit_private_to_public 435,487 435,487 768 768 862,273 862,273 13,152 11,094 -2,058 (-15.6%)
deposit_public_to_private 424,931 424,931 1,984 1,984 965,045 965,045 13,015 11,132 -1,883 (-14.5%)
deposit_public_to_private_exact 424,942 424,942 1,952 1,952 949,469 949,469 12,965 11,045 -1,920 (-14.8%)
deposit_public_to_public 223,800 223,800 832 832 897,563 897,563 9,783 8,280 -1,503 (-15.4%)
issue_private_to_private_exact 611,708 611,708 1,888 1,888 915,976 915,976 16,048 13,731 -2,317 (-14.4%)
issue_private_to_public_exact 484,222 484,222 1,344 1,344 899,998 899,998 13,959 11,849 -2,110 (-15.1%)
issue_public_to_private 346,383 346,383 1,376 1,376 921,661 921,661 11,569 9,829 -1,740 (-15.0%)
issue_public_to_public 223,800 223,800 832 832 898,253 898,253 9,819 8,217 -1,602 (-16.3%)
redeem_private_to_private_exact 614,712 614,712 1,888 1,888 915,823 915,823 16,111 13,692 -2,419 (-15.0%)
redeem_private_to_public 435,430 435,430 768 768 862,717 862,717 13,154 11,191 -1,963 (-14.9%)
redeem_public_to_private_exact 428,003 428,003 1,952 1,952 949,790 949,790 13,037 11,115 -1,922 (-14.7%)
redeem_public_to_public 223,800 223,800 832 832 898,085 898,085 9,707 8,174 -1,533 (-15.8%)
withdraw_private_to_private 510,987 510,987 1,312 1,312 878,458 878,458 14,232 12,031 -2,201 (-15.5%)
withdraw_private_to_private_exact 614,712 614,712 1,888 1,888 915,769 915,769 16,122 13,644 -2,478 (-15.4%)
withdraw_private_to_public_exact 484,165 484,165 1,344 1,344 900,232 900,232 13,983 11,755 -2,228 (-15.9%)
withdraw_public_to_private 441,260 441,260 2,528 2,528 967,356 967,356 13,216 11,192 -2,024 (-15.3%)
withdraw_public_to_public 223,800 223,800 832 832 898,388 898,388 9,743 8,197 -1,546 (-15.9%)

@IlyasRidhuan
IlyasRidhuan merged commit fb8e91b into main Aug 19, 2026
7 checks passed
@IlyasRidhuan
IlyasRidhuan deleted the fix/vault-test-fmt branch August 19, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants