feat!: update address derivation#23151
Open
IlyasRidhuan wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 11, 2026
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
dc34889 to
f8f8953
Compare
IlyasRidhuan
force-pushed
the
ir/04-30-feat_add_immutables_hash_to_contract_instance
branch
from
ab7fc16 to
30d8c61
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
f8f8953 to
9c8d4d8
Compare
IlyasRidhuan
force-pushed
the
ir/04-30-feat_add_immutables_hash_to_contract_instance
branch
from
30d8c61 to
c549ab9
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
9c8d4d8 to
a91ac39
Compare
IlyasRidhuan
force-pushed
the
ir/04-30-feat_add_immutables_hash_to_contract_instance
branch
from
c549ab9 to
c684929
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
2 times, most recently
from
4311e6b to
3457e34
Compare
IlyasRidhuan
force-pushed
the
ir/04-30-feat_add_immutables_hash_to_contract_instance
branch
2 times, most recently
from
8a3f592 to
276df60
Compare
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
3457e34 to
524585d
Compare
IlyasRidhuan
requested review from
LeilaWang,
MirandaWood and
jeanmon
as code owners
jeanmon
approved these changes
May 15, 2026
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
Good job! I have only one nitpick comment.
| // ... ... constructor_fn_selector constructor_args_hash | ||
| // artifact_hash | public_bytecode_commitment salted_initialization_hash | ||
| // | / / \ \ | ||
| // private_function_tree_root deployer_address salt immutables_hash initialization_hash |
Contributor
There was a problem hiding this comment.
nitpick: The order of the elements that we hash is: salt, init_hash, deployer_addr, immutables_hash
which is different as the order in this diagram.
IlyasRidhuan
force-pushed
the
ir/05-05-feat_update_address_derivation
branch
from
524585d to
bf16019
Compare
mverzilli
approved these changes
May 15, 2026
Contributor
mverzilli
left a comment
mverzilli
left a comment
There was a problem hiding this comment.
PXE and stdlib look good to me! I defer to others for other parts of the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of the immutables_hash changes as part of AZIP-9
Updates address derivation to include the
immutables_hash. Specifically,immutables_hashis now part of thesalted_initialization_hashcomputationThis also includes a constant update from
DOM_SEP__CONTRACT_ADDRESS_V1->DOM_SEP__CONTRACT_ADDRESS_V2